Summary: | "Auto renewal" and "Hold reminder" notice shown as "unknown" on the patron category list view | ||
---|---|---|---|
Product: | Koha | Reporter: | Kelly McElligott <kelly> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05
|
|
Circulation function: | |||
Bug Depends on: | 18532 | ||
Bug Blocks: | |||
Attachments: |
visual
Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category Bug 29456: Add Hold_Reminder description to patron categories overview page |
Created attachment 127692 [details] [review] Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Created attachment 127693 [details] [review] Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Works great! Signing off through sandboxes. Created attachment 127783 [details] [review] Bug 29456: (bug 18532 follow-up) handle Auto_Renewals messages in category The new message appears in the list on the edit view, but the list view is showing "unknown" Test plan: Set AutoRenewalNotices to "according to patron messaging prefs" Edit a patron category Tick all the checkboxes On the category list view you should see a correct display in the "Messaging" column Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 127784 [details] [review] Bug 29456: Add Hold_Reminder description to patron categories overview page This was missed when initially adding the notice. To test: - Go to Administraiton > patron categories - Edit a patron category and check "Hold reminder" in messaging preferences, save. - Go to the overview page and verify it shows as 'Unknown'. - Apply patch. - Descrpition should now display. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Strictly speaking this is a string patch, but as the string already exists in other spots, I believe we could be lucky here. And an English string showing would also be better than "Unknown". Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 |
Created attachment 127518 [details] visual When looking at the Patron Category overview, a library gets a glimpse at all the pieces of that patron category. One of the pieces is the summary of notices, currently, the last notice that is listed is called "unknown'- which should be named "auto-renew- see screenshot. This should have the correct text instead of unknown.