Description
Chris Cormack
2010-05-21 01:04:37 UTC
Created attachment 25963 [details] [review] Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in OPAC Coded this old bug against master. Test Plan: 0) set hidelostitems syspref to "Dont show" 1) find/build a biblio with items. 2) from detail page select MARC view and scroll to bottom to see Holdings. 3) go edit the item as lost. 4) from detail page select MARC view and scroll to bottom to see Holdings. (lost item should be gone. And if no other items, no holdings table shown. 5) toggle hidelost items syspref and view again to see lost items appear/disappear 6) you can click plain text view to see that as well Hope you don't mind my changing bug to version: master, since its been so long, and its still an issue in pre 3.14 days. The patch applies. Test plan, the points 1 to 5 are OK but 6 still does not work. (messag: Sorry, plain view is temporarily unavailable.) (Test sandbox) In my test I get no listing of holdings at all on opac-MARCdetail.pl after applying the patch even though there are some items which should not be hidden. Also, is there a reason to leave in this commented-out line? #warn "subf:$i $sf_def->{kohafield} $sf_def->{lib} $subf[$i][0]"; # see errlog to learn the mappings Though bug 10589 and 10895 are in need of a serious re-write, I wonder if they would solve this. Still valid? (In reply to Marc Véron from comment #5) > Still valid? While working on Bug 14385, I think I saw code that was not copied between various opac/opac-###detail.pl files. I think this may still be valid. Created attachment 66211 [details] [review] Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in OPAC Hides the Holdings that are "Lost" and the entire Holdings table if all items are lost, when the hidelostitems syspref is "Don't Show". Should work in plain text view as well. For the OPAC MARC view of a biblio details. Created attachment 66212 [details] [review] Bug 2946: Added some missing logic Created attachment 66213 [details] [review] Bug 2946: Added some missing logic Created attachment 66214 [details] [review] Bug 2946: Added some missing logic Created attachment 66215 [details] [review] Bug 2946 - Lost items (hidden in Normal View) still show up in the MARC View in OPAC Hides the Holdings that are "Lost" and the entire Holdings table if all items are lost, when the hidelostitems syspref is "Don't Show". Should work in plain text view as well. For the OPAC MARC view of a biblio details. Created attachment 66216 [details] [review] Bug 2946: Added some missing logic Created attachment 66284 [details] [review] Bug 2946: Added some missing logic The norequests logic affects the opac-details-sidebar.inc logic which is shared in ISBD and MARC views. It is correct in ISBD and this brings it into MARC detailed view. Pretty sure with is fixed now.. bug 10876 perhaps.. Either way, I can't replicate the bug so I think we're safe to close :) |