Summary: | Umlauts in search field get changed into replacement character | ||
---|---|---|---|
Product: | Koha | Reporter: | Peter Vashchuk <stalkernoid> |
Component: | Circulation | Assignee: | Peter Vashchuk <stalkernoid> |
Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, joonas.kylmala, kyle.m.hall, kyle, m.de.rooy, nugged |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00
|
|
Bug Depends on: | 15812 | ||
Bug Blocks: | |||
Attachments: |
Bug 29463: Escape utf8 characters before appending search query to url.
Bug 29463: Escape utf8 characters before appending search query to url Bug 29463: Escape utf8 characters before appending search query to url |
Description
Peter Vashchuk
2021-11-12 10:27:43 UTC
Comment hidden (obsolete)
Our customers can't search for patrons with umlauts in their names using the "Check out" search menu on the main page of Koha. Other search menus seem to work fine. To reproduce: 1) Go to the main page of Koha and in the "Check out" search window type something like "näyttö". Press the search button. 2) See that it gets replaced with a replacement character. Created attachment 127583 [details] [review] Bug 29463: Escape utf8 characters before appending search query to url. To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. Created attachment 127593 [details] [review] Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Regression from bug 15812, would be nice to get this in before the 21.11 release. Created attachment 127846 [details] [review] Bug 29463: Escape utf8 characters before appending search query to url To test: 1) go to the main page of Koha and search in the "Check out" search window type "näyttö". 2) see that umlauts got replaced with replacement characters. 3) apply the patch. 4) repeat 1-2, ensure that umlauts displayed correctly and are not getting replaced with replacement characters. JK: remove period from commit title Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 21.11, thanks to everybody involved! |