| Summary: | MARC21: 520 - Summary etc. doesn't display in staff interface | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | MARC Bibliographic data support | Assignee: | Katrin Fischer <katrin.fischer> |
| Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | bugzilla, lucas, m.de.rooy, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
23.11.00,23.05.02,22.11.08
|
|
| Circulation function: | |||
| Attachments: |
Bug 29471: Add display of MARC 520 to staff interface detail page
Bug 29471: Add display of MARC 520 to staff interface detail page Bug 29471: Add display of MARC 520 to staff interface detail page Bug 29471: Add display of MARC 520 to staff interface detail page |
||
|
Description
Katrin Fischer
2021-11-12 16:08:33 UTC
Created attachment 152906 [details] [review] Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Created attachment 152908 [details] [review] Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Thank you, Phil! Moving to enh. Can understand the inital choice for normal btw.. But at the end every enhancement is a bug fix :) Patience is a good thing: commit 668581b72022c6c0a46b6ccb5f607921f633e1f6 Author: Frédéric Demians <f.demians@tamil.fr> Date: Sun Nov 8 10:28:59 2009 +0100 Improve detail page MARC21 XSL file for 505 and 520 tags + <xsl:call-template name="subfieldSelect"> + <xsl:with-param name="codes">abcu</xsl:with-param> + </xsl:call-template> 520$u is a URL. Please adjust (In reply to Marcel de Rooy from comment #6) > + <xsl:call-template name="subfieldSelect"> > + <xsl:with-param name="codes">abcu</xsl:with-param> > + </xsl:call-template> > > 520$u is a URL. Please adjust Can we do this separately? This is just a copy of the OPAC display. (In reply to Katrin Fischer from comment #7) > (In reply to Marcel de Rooy from comment #6) > > + <xsl:call-template name="subfieldSelect"> > > + <xsl:with-param name="codes">abcu</xsl:with-param> > > + </xsl:call-template> > > > > 520$u is a URL. Please adjust > > Can we do this separately? This is just a copy of the OPAC display. It is 5 minutes of work. Please do it here. The problem is finding the 5 minutes currently, silly as it sounds... I'll try, but not sure when. Created attachment 153474 [details] [review] Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Updated patch for displaying $u as link. Marcel: I messed up the rebase so I ended up with only one patch. If you think it's needed, please push back to NSO. Just a side note, no blocker: + <xsl:if test="marc:subfield[@code='u']"> + <xsl:for-each select="marc:subfield[@code='u']"> The if test is fine, but actually not needed. If you only have the foreach and there is no $u, nothing happens too. Created attachment 153528 [details] [review] Bug 29471: Add display of MARC 520 to staff interface detail page At the moment 520 only displays in the OPAC. With this patch it also displays in the staff interface detail page. To test: * Find a record with 520 or add some 520 entries to a record Note: different ind. 1 values will result in different labels * View the record in the staff interface and the OPAC * Verify only the OPAC shows the 520 entries * Apply patch * Verify now the staff interface displays them as well Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Updated patch for displaying $u as link. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Restored signoff line from Phil. Change only for $u. (In reply to Marcel de Rooy from comment #12) > Just a side note, no blocker: > > + <xsl:if test="marc:subfield[@code='u']"> > + <xsl:for-each select="marc:subfield[@code='u']"> > > The if test is fine, but actually not needed. > If you only have the foreach and there is no $u, nothing happens too. You are right. Tbh I stole this code from another 5xx with $u for some consistency :) Also thank you for adding back the sign-off line - I forgot about it when I rebased my local branch for the addition. Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Nice work everyone! Pushed to oldstable for 22.11.x |