Summary: | Improve display of notices in patron details | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | Notices | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | barbara.johnson, fridolin.somers, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
In patron notices table, notices are now shown in a modal dialog instead of inline in the table.
The "Resend" button is shown in the modal window controls.
|
Version(s) released in: |
22.05.00
|
Circulation function: | |||
Attachments: |
Bug 29491: Improve display of notices in patron details
Bug 29491: (preparatory step) Reindent template Bug 29491: Improve display of notices in patron details Bug 29491: (preparatory step) Reindent template Bug 29491: Improve display of notices in patron details Bug 29491: (preparatory step) Reindent template Bug 29491: Improve display of notices in patron details |
Description
Martin Renvoize (ashimema)
2021-11-16 10:30:25 UTC
Increasing the width of the display box would be helpful. Created attachment 127740 [details] [review] Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Sorry Owen.. I get sha1 issues trying to apply this patch :( Created attachment 127741 [details] [review] Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Created attachment 127742 [details] [review] Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Created attachment 127775 [details] [review] Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Created attachment 127776 [details] [review] Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> This is an excellent improvement, thanks Owen! Signing off Created attachment 128468 [details] [review] Bug 29491: (preparatory step) Reindent template Step 1: Replace tabs with spaces and reindent. This patch should include only whitespace changes. If you view the diff while ignoring whitespace there should be no changes. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 128469 [details] [review] Bug 29491: Improve display of notices in patron details This patch updates the patron notices list so that notices are shown in a modal dialog instead of inline in the table. The "Resend" button is shown in the modal window controls. To test, apply the patch and locate a patron in the staff interface with multiple sent notices. - View the patron's "Notices" tab. - In the table of notices, click one of the notice titles. - A modal window should appear with the notice subject as the header and the notice content in the main body of the modal. - If the message has any other status than 'pending' there should be a "Resend" button in the modal footer. Confirm that it submits the form and resends the correct message. - Try viewing multiple notices to confirm that the contents of the modal are correctly updated for each message. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |