Summary: | Remove usage of deprecated Mojolicious::Routes::Route::detour | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Architecture, internals, and plumbing | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | normal | ||
Priority: | P5 - low | CC: | andrew, fridolin.somers, kyle, mtj, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03
|
|
Circulation function: | |||
Attachments: |
Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour
Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour |
Description
Julian Maurice
2021-11-17 06:18:25 UTC
Created attachment 127705 [details] [review] Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works Created attachment 128676 [details] [review] Bug 29498: Remove usage of deprecated Mojolicious::Routes::Route::detour Mojolicious::Routes::Route::detour was deprecated in Mojolicious 8.67 and removed in Mojolicious 9 It was used in Koha::App::Plugin::RESTV1 to connect the "REST API" Mojolicious app to the other Mojolicious apps (Koha::App::Intranet and Koha::App::Opac), so it's only a problem when running Koha as a Mojolicious app. This patch makes use of the "partial" attribute instead, which does the same thing. Test plan: 1. Run `morbo bin/intranet` 2. Point your browser to what morbo says (should be localhost:3000) 3. Log in, and go to Administration » Libraries. This table uses the REST API, so if you see data in it, that means the API (and the patch) works Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Trivial change that prepares the ground for upgrading Mojolicious (in the works). Works as expected, passes the QA checks. Straight QA as it will hardly find a good soul to QA it sooner than later. Maybe we need a new component for Koha as a Mojolicious app. Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.03 Not backporting to 21.05, please ask if needed. |