Summary: | Remove dependency on IO::Scalar | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Architecture, internals, and plumbing | Assignee: | Julian Maurice <julian.maurice> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | jonathan.druart, kyle |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Attachments: |
Bug 29516: Remove dependency on IO::Scalar
Bug 29516: Remove dependency on IO::Scalar |
Description
Julian Maurice
2021-11-18 11:43:18 UTC
Created attachment 127785 [details] [review] Bug 29516: Remove dependency on IO::Scalar IO::Scalar is used in Koha::App::Plugin::CGIBinKoha to create a filehandle tied to a scalar. Perl has this feature built in since 5.8.0 so IO::Scalar is not needed I'm not sure how to test this, since it should behave exactly the same with or without the patch, but we can at least verify that it doesn't introduce encoding issues. Test plan: 1. Run `morbo bin/intranet` 2. Go to http://localhost:3000 3. Create a bibliographic record with some non-latin characters (try emoji characters for instance). Verify that there is no visible encoding issues. 4. Save this record as MARCXML and re-import it as a new record using Tools » Stage MARC records for import. Verify that the new record has no visible encoding issues 5. `git grep IO::Scalar` should not return any result Created attachment 128548 [details] [review] Bug 29516: Remove dependency on IO::Scalar IO::Scalar is used in Koha::App::Plugin::CGIBinKoha to create a filehandle tied to a scalar. Perl has this feature built in since 5.8.0 so IO::Scalar is not needed I'm not sure how to test this, since it should behave exactly the same with or without the patch, but we can at least verify that it doesn't introduce encoding issues. Test plan: 1. Run `morbo bin/intranet` 2. Go to http://localhost:3000 3. Create a bibliographic record with some non-latin characters (try emoji characters for instance). Verify that there is no visible encoding issues. 4. Save this record as MARCXML and re-import it as a new record using Tools » Stage MARC records for import. Verify that the new record has no visible encoding issues 5. `git grep IO::Scalar` should not return any result Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Trivial, skipping QA. Pushed to master for 22.05, thanks to everybody involved [U+1F984] |