Summary: | Patron Club name hyperlinks not operational + weird CSS behavior | ||
---|---|---|---|
Product: | Koha | Reporter: | Myka Kennedy Stephens <mkstephens> |
Component: | Tools | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, david, fridolin.somers, kyle, victor |
Version: | Main | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This removes the link from thea patron club name on the patrons club listing page as it didn't work. It also improves the consistency of the table of patron clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view.
|
Version(s) released in: |
22.05.00,21.11.01,21.05.08
|
Circulation function: | |||
Bug Depends on: | 24627 | ||
Bug Blocks: | |||
Attachments: |
Bug 29521: Fix style of patron clubs table when in clubs management
Bug 29521: Fix style of patron clubs table when in clubs management Bug 29521: Fix style of patron clubs table when in clubs management |
Description
Myka Kennedy Stephens
2021-11-18 18:49:43 UTC
Created attachment 127818 [details] [review] Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Created attachment 127849 [details] [review] Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Created attachment 127864 [details] [review] Bug 29521: Fix style of patron clubs table when in clubs management This patch follows up Bug 24627 to add some additional template logic to the table of clubs so that the interface is consistent whether you're looking at clubs during the holds process or during the clubs management view. The ways Bug 24627 made the clubs list more consistent with patron search results made it LESS consistent with the Clubs management interface. To test, apply the patch and go to Tools -> Patron clubs. - Scroll down to the "Clubs" table, below the "Club templates" table. - In the table of clubs, the club name should not be a link. - Hovering your mouse over the table should not highlight each row. Confirm the previous behavior of a clubs search when placing a hold: - Search the catalog and start the process of placing a hold on an item. - On the "Place hold" page, click the "Clubs" tab and perform a search which will return multiple clubs. - In this view, the club name should be a link. Clicking it should select that club for the hold. - You should also be able to click anywhere in the row to select the club for the hold. Signed-off-by: Andreas Roussos <a.roussos@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved! Pushed to 21.11.x for 21.11.01 Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. Pushed to 21.05.x for 21.05.08 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |