Summary: | Cannot set a new value for privacy_guarantor_checkouts in memberentry.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Patrons | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
Severity: | critical | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, jonathan.druart, kyle.m.hall, kyle, nugged, sally.healey, victor, wainuiwitikapark |
Version: | Main | Keywords: | rel_20_11_candidate |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
21.11.00,21.05.05,20.11.12,20.05.18,19.11.24
|
|
Circulation function: | |||
Bug Depends on: | 28935 | ||
Bug Blocks: | |||
Attachments: |
Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes
Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes |
Description
Lucas Gass (lukeg)
2021-11-19 00:51:32 UTC
Caused by commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages Created attachment 127928 [details] [review] Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Created attachment 127931 [details] [review] Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard <oleonard@myacpl.org> Created attachment 127935 [details] [review] Bug 29524: (bug 28935 follow-up) Restore modification of some patron's attributes On commit 5f37d8d2f496ce3c9fd6dfd5a2efa7a9fe435af3 Bug 28935: No filtering on patron's data on member entry pages we restricted the list of the columns from the borrowers table that can be modified from the patron edit view. We were too restrictive, the following 3 attributes can be edited from this form: privacy_guarantor_fines, privacy_guarantor_checkouts, checkprevcheckout and lang Test plan: Turn on the following prefs: - AllowStaffToSetFinesVisibilityForGuarantor - AllowStaffToSetCheckoutsVisibilityForGuarantor - CheckPrevCheckout (set to 'unless overridden *') - TranslateNotices Edit a patron and see the 4 different options are now displayed. Change their value, save, edit again Confirm that the values have been saved Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 21.11, thanks to everybody involved! Pushed to 21.05.x for 21.05.05 Pushed to 20.11.x for 20.11.12 Backported: Pushed to 20.05.x branch for 20.05.18 Backported: Pushed to 19.11.x branch for 19.11.24 *** Bug 29250 has been marked as a duplicate of this bug. *** |