Summary: | Fix \n in hint on Koha to MARC mappings | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | trivial | ||
Priority: | P5 - low | CC: | andrewfh, david, fridolin.somers, kyle, victor |
Version: | master | Keywords: | Manual |
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | String patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This fixes:
- a string in Koha to MARC mappings (koha2marclinks.tt:86) so that it can be correctly translated (excludes "\n" from what is translated), and
- capitalization for the breadcrumb link: Administration > Koha to MARC mappings.
|
Version(s) released in: |
22.05.00,21.11.01,21.05.08
|
Attachments: |
Bug 29529: Fix \n in hint on Koha to MARC mappings
Bug 29529: Fix \n in hint on Koha to MARC mappings Bug 29529: Fix \n in hint on Koha to MARC mappings |
Description
Katrin Fischer
2021-11-19 13:57:26 UTC
Created attachment 127876 [details] [review] Bug 29529: Fix \n in hint on Koha to MARC mappings This patch breaks up a translatable string so that "\n" is excluded from what is translated. Unrelated: Capitalization is corrected on an instance of the phrase "Koha to MARC Mappings." To test, apply the patch and go to Administration -> Koha to MARC mapping. - The breadcrumb for the current page should have correct capitalization ("mapping" instead of "Mapping"). - Click the "Add" button for any Koha field. The dialog should display correctly: Adding a mapping for: biblio.abstract. Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.) The change will be applied immediately. Test the way the po file is updated: > cd misc/translator > perl translate update en-GB (for example) - Open the updated po file, en-GB-staff-prog.po - You should find these lines: SCRIPT koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 msgid "The change will be applied immediately." msgstr "" Created attachment 128015 [details] [review] Bug 29529: Fix \n in hint on Koha to MARC mappings This patch breaks up a translatable string so that "\n" is excluded from what is translated. Unrelated: Capitalization is corrected on an instance of the phrase "Koha to MARC Mappings." To test, apply the patch and go to Administration -> Koha to MARC mapping. - The breadcrumb for the current page should have correct capitalization ("mapping" instead of "Mapping"). - Click the "Add" button for any Koha field. The dialog should display correctly: Adding a mapping for: biblio.abstract. Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.) The change will be applied immediately. Test the way the po file is updated: > cd misc/translator > perl translate update en-GB (for example) - Open the updated po file, en-GB-staff-prog.po - You should find these lines: SCRIPT koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 msgid "The change will be applied immediately." msgstr "" Signed-off-by: David Nind <david@davidnind.com> Created attachment 128027 [details] [review] Bug 29529: Fix \n in hint on Koha to MARC mappings This patch breaks up a translatable string so that "\n" is excluded from what is translated. Unrelated: Capitalization is corrected on an instance of the phrase "Koha to MARC Mappings." To test, apply the patch and go to Administration -> Koha to MARC mapping. - The breadcrumb for the current page should have correct capitalization ("mapping" instead of "Mapping"). - Click the "Add" button for any Koha field. The dialog should display correctly: Adding a mapping for: biblio.abstract. Please enter field tag and subfield code, separated by a comma. (For control fields: add '@' as subfield code.) The change will be applied immediately. Test the way the po file is updated: > cd misc/translator > perl translate update en-GB (for example) - Open the updated po file, en-GB-staff-prog.po - You should find these lines: SCRIPT koha-tmpl/intranet-tmpl/prog/en/modules/admin/koha2marclinks.tt:86 msgid "The change will be applied immediately." msgstr "" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 22.05, thanks to everybody involved! Pushed to 21.11.x for 21.11.01 Added Manual keyword for 22.05 bugs that I consider require documentation changes. See bug 29640 and the linked spreadsheet for additional details. Pushed to 21.05.x for 21.05.08 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |