| Summary: | Auto-renewals digest reports on 'auto_too_soon' | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Nick Clemens (kidclamp) <nick> |
| Component: | Circulation | Assignee: | Bugs List <koha-bugs> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | dcook, gmcharlt, kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Attachments: |
Bug 29555: Don't push auto_too_soon issues into report
Bug 29555: Don't push auto_too_soon issues into report |
||
|
Description
Nick Clemens (kidclamp)
2021-11-22 13:26:02 UTC
Created attachment 127929 [details] [review] Bug 29555: Don't push auto_too_soon issues into report This patch adds a conditional to avoid reporting on issues that are too soon to be renewed To test: 1 - Set AutoRenewalNotices preference to 'according to patron messaging preferences' 2 - Set a patront o request auto renewal emails digested 3 - Checkout an item to the patron, back dated to be opverdue, and marked for auto renewal 4 - Add an email to the patron for testing 5 - perl misc/cronjobs/automatic_renewals.pl -v -c 6 - See the issue is renewed (ensure it is now not overdue) 7 - Confirm the patron was sent a digest with the renewal (on patron 'Notices' tab) 8 - perl misc/cronjobs/automatic_renewals.pl -v -c 9 - See the issue was not renewed 10 - See a notice was sent, with no indication of what happened to the issue 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v -c 13 - Confrim no renewal or notice 14 - Checkout a second item to patron, backdated and set for auto renewal 15 - perl misc/cronjobs/automatic_renewals.pl -v -c 16 - Confirm the correct item is renewed and notice sent 17 - Confirm notice does not include the too soon issue 18 - Checkout a third item 19 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 20 - Confirm correct item is renewed and notice sent, nbot including other two 21 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 22 - Confirm no notice sent Created attachment 127934 [details] [review] Bug 29555: Don't push auto_too_soon issues into report This patch adds a conditional to avoid reporting on issues that are too soon to be renewed To test: 1 - Set AutoRenewalNotices preference to 'according to patron messaging preferences' 2 - Set a patront o request auto renewal emails digested 3 - Checkout an item to the patron, back dated to be opverdue, and marked for auto renewal 4 - Add an email to the patron for testing 5 - perl misc/cronjobs/automatic_renewals.pl -v -c 6 - See the issue is renewed (ensure it is now not overdue) 7 - Confirm the patron was sent a digest with the renewal (on patron 'Notices' tab) 8 - perl misc/cronjobs/automatic_renewals.pl -v -c 9 - See the issue was not renewed 10 - See a notice was sent, with no indication of what happened to the issue 11 - Apply patch 12 - perl misc/cronjobs/automatic_renewals.pl -v -c 13 - Confrim no renewal or notice 14 - Checkout a second item to patron, backdated and set for auto renewal 15 - perl misc/cronjobs/automatic_renewals.pl -v -c 16 - Confirm the correct item is renewed and notice sent 17 - Confirm notice does not include the too soon issue 18 - Checkout a third item 19 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 20 - Confirm correct item is renewed and notice sent, nbot including other two 21 - perl misc/cronjobs/automatic_renewals.pl -v -c -b 22 - Confirm no notice sent Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> |