Summary: | Auto renew notices should handle failed renewal due to patron expiration | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
Component: | Notices | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart, kyle, rcoert, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Small patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: |
This enhancement updates the default auto-renewal notices to tell patrons that their renewals have failed because their account has expired.
|
|
Version(s) released in: |
22.05.00,21.11.02,21.05.09
|
Circulation function: | |
Bug Depends on: | 19444 | ||
Bug Blocks: | |||
Attachments: |
Bug 29557: Add auto_account_expired to AUTO_RENEWALS
Bug 29557: Add auto_account_expired to AUTO_RENEWALS Bug 29557: Add auto_account_expired to AUTO_RENEWALS Bug 29557: (QA follow-up) Add note for translated notices to update statement |
Description
Andrew Fuerste-Henry
2021-11-22 16:07:02 UTC
Created attachment 127956 [details] [review] Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? Created attachment 128099 [details] [review] Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? Signed-off-by: David Nind <david@davidnind.com> Testing notes: - Ran auto renewal cron job as follows: perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm I am in doubt about the database update as this will only work for notices that haven't been changed - including untranslated. But it doesn't hurt to update unchanged notices, so we can keep it. But maybe we could add a note to the update statement about updating your notice if you have changed them? Attaching a patch to do this. Created attachment 128707 [details] [review] Bug 29557: Add auto_account_expired to AUTO_RENEWALS It was missing and the notice sent was not providing the reason of the failure. Test plan: Check an item out with a date in the past, mark it as auto renew Modify the expired date of the patron and set it in the past Run the automatic_renewals.pl cronjob script, confirm that the notice now contains the reason of the failure. QA note: The template will be updated only for English installations. Should we add an alert for others? Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 128708 [details] [review] Bug 29557: (QA follow-up) Add note for translated notices to update statement Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> While pushing master, I've moved note in dbrev into a "say $out". Renders better : kohadev-koha@kohadevbox:/kohadevbox/koha$ ./installer/data/mysql/updatedatabase.pl Upgrade to 21.12.00.006 [21:50:56]: Bug 29557 - Add auto_account_expired to AUTO_RENEWALS notice Please update your AUTO_RENEWALS notice manually if you have changed or translated it Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.02 Pushed to 21.05.x for 21.05.09 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |