Bug 29563

Summary: Version 21.05.05 is missing database update
Product: Koha Reporter: Magnus Enger <magnus>
Component: Installation and upgrade (command-line installer)Assignee: Kyle M Hall (khall) <kyle>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: dcook, jonathan.druart
Version: 21.05   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Magnus Enger 2021-11-23 20:52:17 UTC
The increment to 21.05.05 was done in these two commits:
https://git.koha-community.org/Koha-community/Koha/commit/d4f60deeb7f157177ccbff44e7e7e4c83c992e22
https://git.koha-community.org/Koha-community/Koha/commit/ba30e76d1a08ef84e66583cd4638f6150ffdeee2

But these commits do not update the database, only Koha.pm. Here is what it usually looks like:
https://git.koha-community.org/Koha-community/Koha/commit/b17cf65633107306bd5d423998a50b65aaecce65

So if you check out the 21.05.05 tag, Koha.pm says:
$VERSION = "21.05.05.000";

But the last DB update in installer/data/mysql/updatedatabase.pl is this:
$DBversion = '21.05.04.003';
if( CheckVersion( $DBversion ) ) {
    $dbh->do( q{
        INSERT IGNORE INTO systempreferences (variable, value, options, explanation, type)
        VALUES ('CreateAVFromCataloguing', '1', '', 'Ability to create authorized values from the cataloguing module', 'YesNo')
    });
    NewVersion( $DBversion, 29137, "Add system preference CreateAVFromCataloguing");
}
Comment 1 Jonathan Druart 2021-11-24 08:10:06 UTC
v21.05.05 is broken and will stay broken. However I think we fixed the package, and the current origin/21.05.x branch seems to be ok
Comment 2 Kyle M Hall (khall) 2021-11-24 10:09:17 UTC
(In reply to Jonathan Druart from comment #1)
> v21.05.05 is broken and will stay broken. However I think we fixed the
> package, and the current origin/21.05.x branch seems to be ok

That is correct. The packages were fixed by Mason IIRC!
Comment 3 Magnus Enger 2021-11-24 13:44:07 UTC
> That is correct. The packages were fixed by Mason IIRC!

OK. I was seeing this because I was upgrading a gitifed install to 21.05.05.