Bug 29564

Summary: Use List::MoreUtils so SIP U16/Xenial does not break
Product: Koha Reporter: Mason James <mtj>
Component: SIP2Assignee: Mason James <mtj>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: blocker    
Priority: P5 - low CC: david, fridolin.somers, jonathan.druart, kyle, victor, wainuiwitikapark
Version: MainKeywords: rel_20_11_candidate, rel_21_05_candidate
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29264
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
21.11.00,21.05.07,20.11.12,20.05.18
Bug Depends on: 29264    
Bug Blocks:    
Attachments: to test...
Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break
Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break
Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break

Description Mason James 2021-11-24 01:57:29 UTC
patch to come...
Comment 2 Mason James 2021-11-24 02:05:48 UTC
Created attachment 127970 [details] [review]
Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break

- run prove t/00-load.t, see error
 - apply patch

    00:07:08.189 koha_1       | #   Failed test 'use C4::SIP::Sip::Configuration;'
    00:07:08.189 koha_1       | #   at t/00-load.t line 46.
    00:07:08.189 koha_1       | #     Tried to use 'C4::SIP::Sip::Configuration'.
    00:07:08.189 koha_1       | #     Error:  "uniq" is not exported by the List::Util module

 - run prove t/00-load.t, see tests pass :0)

https://bugs.koha-community.org/show_bug.cgi?id=29478
Comment 3 David Nind 2021-11-24 20:04:15 UTC
Created attachment 127986 [details] [review]
Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break

- run prove t/00-load.t, see error
 - apply patch

    00:07:08.189 koha_1       | #   Failed test 'use C4::SIP::Sip::Configuration;'
    00:07:08.189 koha_1       | #   at t/00-load.t line 46.
    00:07:08.189 koha_1       | #     Tried to use 'C4::SIP::Sip::Configuration'.
    00:07:08.189 koha_1       | #     Error:  "uniq" is not exported by the List::Util module

 - run prove t/00-load.t, see tests pass :0)

Signed-off-by: David Nind <david@davidnind.com>
Comment 4 David Nind 2021-11-24 20:10:10 UTC
Testing notes using koha-testing-docker (KTD):

- To start KTD using U16/xenial change KOHA_IMAGE=master-xenial in your .env file
Comment 5 Victor Grousset/tuxayo 2021-11-24 23:59:53 UTC
Created attachment 127987 [details] [review]
Bug 29564: Use List::MoreUtils so SIP U16/Xenial does not break

 - run prove t/00-load.t, see error
 - apply patch

    00:07:08.189 koha_1       | #   Failed test 'use C4::SIP::Sip::Configuration;'
    00:07:08.189 koha_1       | #   at t/00-load.t line 46.
    00:07:08.189 koha_1       | #     Tried to use 'C4::SIP::Sip::Configuration'.
    00:07:08.189 koha_1       | #     Error:  "uniq" is not exported by the List::Util module

 - run prove t/00-load.t, see tests pass :0)

https://bugs.koha-community.org/show_bug.cgi?id=29478

https://bugs.koha-community.org/show_bug.cgi?id=29564

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Comment 6 Victor Grousset/tuxayo 2021-11-25 01:08:30 UTC
Our use case is simple so switching to List::MoreUtils:uniq shouldn't change the behavior.
List::MoreUtils is already even in 19.11.x so it's not a new dep.

Look good for QA :)
Comment 7 Jonathan Druart 2021-11-25 09:05:14 UTC
Pushed to master for 21.11, thanks to everybody involved!
Comment 8 Mason James 2021-11-26 08:36:43 UTC
hi, can we get this pushed back to 20.05.x branch please :0)
Comment 9 Fridolin Somers 2021-11-30 06:18:24 UTC
Early pushed to 20.11.x for 20.11.12
Comment 10 Kyle M Hall 2021-11-30 16:57:13 UTC
Pushed to 21.05.x for 21.05.05
Comment 11 Kyle M Hall 2021-11-30 16:57:44 UTC
Pushed to 21.05.x for 21.05.07, not .05
Comment 12 Victor Grousset/tuxayo 2021-11-30 23:32:47 UTC
Backported: Pushed to 20.05.x branch for 20.05.18
Comment 13 wainuiwitikapark 2021-12-01 23:02:33 UTC
Should this be backported to 19.11.x?
Comment 14 Victor Grousset/tuxayo 2021-12-02 02:11:01 UTC
Nope, it was a regression due to bug 29264 so you dodged a bullet ^^
Comment 15 wainuiwitikapark 2021-12-02 21:47:11 UTC
(In reply to Victor Grousset/tuxayo from comment #14)
> Nope, it was a regression due to bug 29264 so you dodged a bullet ^^

Cool, I thought that was the case. Thank you!!