| Summary: | "Hold reminder" notice doesn't show in messaging preferences in new installation | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> | 
| Component: | Notices | Assignee: | Nick Clemens (kidclamp) <nick> | 
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Severity: | critical | ||
| Priority: | P5 - low | CC: | andrew, david, fridolin.somers, jonathan.druart, kyle, nick, nugged, tomascohen | 
| Version: | Main | Keywords: | rel_21_11_candidate | 
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | 
       This fixes an issue with the installer files that meant "Hold reminder" notices were not shown in messaging preferences for new installations. 
 | 
        |
| Version(s) released in: | 
       22.05.00,21.11.01 
 | 
        
        Circulation function: | |
| Bug Depends on: | 28153 | ||
| Bug Blocks: | |||
| Attachments: | 
              Bug 29586: Fix typos in installer files
               Bug 29586: Fix typos in installer files Bug 29586: Add atomic update for existing intallations Bug 29586: Fix typos in installer files Bug 29586: Add atomic update for existing intallations Bug 29586: Fix typos in installer files Bug 29586: Add atomic update for existing intallations  | 
      ||
| 
 
        
          Description
        
        
          Katrin Fischer
        
        
        
        
          2021-11-28 16:58:14 UTC
        
       
    Created attachment 128069 [details] [review] Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Hi Nick, could you provide a database update as well? As we already released we might have .0 databases that need it. How is that possible?! No idea why DBIx::RunSQL is not failing... Not sure how to prevent that from happening again. (In reply to Jonathan Druart from comment #4) > No idea why DBIx::RunSQL is not failing... Not sure how to prevent that from > happening again. I fully understand your grumpiness, let's fix that and then go to the source of the issue. Created attachment 128119 [details] [review] Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 128120 [details] [review] Bug 29586: Add atomic update for existing intallations In case an installation was created on 21.11.00 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 128123 [details] [review] Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 128124 [details] [review] Bug 29586: Add atomic update for existing intallations In case an installation was created on 21.11.00 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Created attachment 128447 [details] [review] Bug 29586: Fix typos in installer files When HOLD_REMINDER info was added I neglected to move the semicolons, this meant the statements were ending before the data was added Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 128448 [details] [review] Bug 29586: Add atomic update for existing intallations In case an installation was created on 21.11.00 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Good catch! Trivial fix, working as expected and QA scripts happy. We need a script to catch those in the QA tools. Pushed to master for 22.05, thanks to everybody involved [U+1F984] Missing dependencies, not backported to 21.05 (In reply to Andrew Fuerste-Henry from comment #14) > Missing dependencies, not backported to 21.05 I think this needs to be pushed to 21.11 urgently, but seems to have been pushed and then reverted? https://git.koha-community.org/Koha-community/Koha/commits/branch/21.11.x Kyle, can you clarify? Andrew, you should check for your version only after Kyle has pushed. Pushed to 21.11.x for 21.11.01  |