| Summary: | Allow an English sql localization script | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Installation and upgrade (command-line installer) | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | ||
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 29673: Allow English sql localization script
Bug 29673: Allow English sql localization script |
||
|
Description
Marcel de Rooy
2021-12-09 15:06:53 UTC
DBIx::RunSQL is quite stupid on splitting by newlines btw.. Created attachment 128386 [details] [review] Bug 29673: Allow English sql localization script Test plan: You might want to add a simple SQL statement to your English custom.sql in order to verify the execution. Run a Koha install (in English). Check if the data shows your custom sql action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> See bug 13669 comment71 showing that you cannot add functions or procedures in a sql file run by DBIx::RunSQL. Changes one line, adds two comments. More or less a no-op to allow simple customization. Waiting for 10 months. Still applies. Moving it to the next queue.. Created attachment 139164 [details] [review] Bug 29673: Allow English sql localization script Test plan: You might want to add a simple SQL statement to your English custom.sql in order to verify the execution. Run a Koha install (in English). Check if the data shows your custom sql action. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 22.11. Nice work everyone, thanks! |