Bug 29703

Summary: Simplify GetBranchItemRule using get_effective_rules
Product: Koha Reporter: Nick Clemens <nick>
Component: Architecture, internals, and plumbingAssignee: Nick Clemens <nick>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart, kyle
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Attachments: Bug 29703: Use get_effective_rules in GetBranchItemRule
Bug 29703: Use get_effective_rules in GetBranchItemRule
Bug 29703: Use get_effective_rules in GetBranchItemRule

Description Nick Clemens 2021-12-15 16:27:09 UTC
Possibly we should work towards removing this sub, but for now we should use get_effective_rules rather than calling get_effective rule three times
Comment 1 Nick Clemens 2021-12-15 16:28:32 UTC
Created attachment 128574 [details] [review]
Bug 29703: Use get_effective_rules in GetBranchItemRule

To test:
1 - prove -v t/db_dependent/Circulation/Branch.t
Comment 2 Michal Denar 2022-02-17 21:33:50 UTC
Created attachment 130771 [details] [review]
Bug 29703: Use get_effective_rules in GetBranchItemRule

To test:
1 - prove -v t/db_dependent/Circulation/Branch.t

Signed-off-by: Michal Denar <black23@gmail.com>
Comment 3 Jonathan Druart 2022-02-18 09:07:17 UTC
Created attachment 130812 [details] [review]
Bug 29703: Use get_effective_rules in GetBranchItemRule

To test:
1 - prove -v t/db_dependent/Circulation/Branch.t

Signed-off-by: Michal Denar <black23@gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Fridolin Somers 2022-02-25 00:36:33 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄