| Summary: | Holds reminder emails should allow configuration for a specific number of days | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrew Fuerste-Henry <andrew> |
| Component: | Hold requests | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | bwsdonna, gmcharlt, kyle, lucas, rcoert, sbrown, tomascohen, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03,21.05.14
|
|
| Circulation function: | |||
| Bug Depends on: | 15986 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29704: Add a triggered option to holds_reminder.pl
Bug 29704: Add a triggered option to holds_reminder.pl Bug 29704: Add a triggered option to holds_reminder.pl |
||
|
Description
Andrew Fuerste-Henry
2021-12-15 19:50:08 UTC
Created attachment 128680 [details] [review] Bug 29704: Add a triggered option to holds_reminder.pl This patch adds an option to only trigger notices matching the number of days waiting specified You will need to define HOLD_REMINDER notices for the specific branch of the patron and ensure the patron has hold reminder notices in their messaging preferences TO test: 1 - Place a hold for a patron and check in to confirm 2 - Set the waiting date back a few days: update reserves set waitingdate = DATE_SUB(CURDATE(), INTERVAL 5 DAY); 3 - Run the cron and see that patron would be notified if running for 4 days weaiting perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 4 - Apply patch 5 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 --triggered 6 - Note patron would not be notified 7 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 5 --triggered 8 - Note patron is notified when days waiting matches exactly Created attachment 129042 [details] [review] Bug 29704: Add a triggered option to holds_reminder.pl This patch adds an option to only trigger notices matching the number of days waiting specified You will need to define HOLD_REMINDER notices for the specific branch of the patron and ensure the patron has hold reminder notices in their messaging preferences TO test: 1 - Place a hold for a patron and check in to confirm 2 - Set the waiting date back a few days: update reserves set waitingdate = DATE_SUB(CURDATE(), INTERVAL 5 DAY); 3 - Run the cron and see that patron would be notified if running for 4 days weaiting perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 4 - Apply patch 5 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 --triggered 6 - Note patron would not be notified 7 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 5 --triggered 8 - Note patron is notified when days waiting matches exactly Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 129114 [details] [review] Bug 29704: Add a triggered option to holds_reminder.pl This patch adds an option to only trigger notices matching the number of days waiting specified You will need to define HOLD_REMINDER notices for the specific branch of the patron and ensure the patron has hold reminder notices in their messaging preferences TO test: 1 - Place a hold for a patron and check in to confirm 2 - Set the waiting date back a few days: update reserves set waitingdate = DATE_SUB(CURDATE(), INTERVAL 5 DAY); 3 - Run the cron and see that patron would be notified if running for 4 days weaiting perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 4 - Apply patch 5 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 4 --triggered 6 - Note patron would not be notified 7 - perl misc/cronjobs/holds/holds_reminder.pl -v --days 5 --triggered 8 - Note patron is notified when days waiting matches exactly Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Any chance this will get a backport for 21.11 and 21.05? Pushed to 21.11.x for 21.11.03 Missing dependency, not backported to 21.05 (In reply to Andrew Fuerste-Henry from comment #7) > Missing dependency, not backported to 21.05 Does not rely on 28153 - only 15986 - please reconsider? Pushed to 21.05.x for 21.05.14 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |