Summary: | Test suite has some IssuingRules left-overs | ||
---|---|---|---|
Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
Component: | Test Suite | Assignee: | Fridolin Somers <fridolin.somers> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | ||
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Bug Depends on: | 18936 | ||
Bug Blocks: | |||
Attachments: |
Bug 29705: In test suite merge IssuingRules with CirculationRules
Bug 29705: In test suite merge IssuingRules with CirculationRules Bug 29705: In test suite merge IssuingRules with CirculationRules Bug 29705: In test suite merge IssuingRules with CirculationRules Bug 29705: In test suite merge IssuingRules with CirculationRules Bug 29705: In test suite merge IssuingRules with CirculationRules |
Description
Fridolin Somers
2021-12-15 21:18:42 UTC
Created attachment 128577 [details] [review] Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Created attachment 129045 [details] [review] Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Created attachment 129138 [details] [review] Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t and prove t/db_dependent/Koha/CirculationRules/* Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Oups t/db_dependent/Koha/IssuingRules.t fails. We can remove the file. And there is still t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. We should simply rename forder. (In reply to Fridolin Somers from comment #4) > Oups > > t/db_dependent/Koha/IssuingRules.t fails. > We can remove the file. > > And there is still > t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t. > We should simply rename forder. I mean t/db_dependent/Circulation/IssuingRules I move maxsuspensiondays.t to parent folder and remove IssuingRules folder Created attachment 129464 [details] [review] Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t Created attachment 134439 [details] [review] Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t Signed-off-by: David Nind <david@davidnind.com> I tried testing here, but the QA test tools get stuck again having me end up on qa-current-commit branch with untracekd files in t/db_dependent/Koha/CirculationRules/ :( Created attachment 134682 [details] [review] Bug 29705: In test suite merge IssuingRules with CirculationRules After Bug 18936, in test suite, there is still t/db_dependent/Koha/IssuingRules.t and t/db_dependent/Koha/IssuingRules/ This patch moves IssuingRules.t inside CirculationRules.t and renames dir t/db_dependent/Koha/IssuingRules. And adds DB transation in each first-level subtest. Also renames in : use constant GUESSED_ITEMTYPES_KEY => 'Koha_IssuingRules_last_guess'; Test plan : Run prove t/db_dependent/Koha/CirculationRules.t prove t/db_dependent/Koha/CirculationRules/* prove t/db_dependent/Circulation/maxsuspensiondays.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |