Summary: | Release date not passed as ISO to about.tt | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | david, fridolin.somers, jonathan.druart |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29718 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30718 |
||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 29403 | ||
Bug Blocks: | |||
Attachments: | Bug 29711: Pass release date in ISO to about.tt |
Description
Tomás Cohen Arazi (tcohen)
2021-12-16 14:21:09 UTC
Created attachment 128627 [details] [review] Bug 29711: Pass release date in ISO to about.tt This patch makes the date be converted into ISO format so it is correctly handled by the KohaDates TT filter. To test: 1. Point your browser to the about page => FAIL: It explodes: Template process failed: undef error - The given date (2022-05-22T00:00:01) does not match the date format (iso) 2. Apply this patch 3. Restart: $ koha-plack --restart kohadev 4. Repeat 1 => SUCCESS: It doesn't explode, shows the right date! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> This is really ugly... I meant, not your patch :) But what we need to do. That is plain wrong. I can't replicate this on master and using KTD. Does this only apply for a specific version? (In reply to David Nind from comment #4) > I can't replicate this on master and using KTD. Same for me. And I dont see where this date is used. No idea why this has been magically fixed.. If there is something to clean, it will be on bug 30718. (In reply to Jonathan Druart from comment #6) > No idea why this has been magically fixed.. DateTime magician, I summon theeeeee |