Bug 29721

Summary: automatic_renewal.pl dies if patrons choose SMS for digests and there is no SMS template defined
Product: Koha Reporter: Lucas Gass (lukeg) <lucas>
Component: CirculationAssignee: Bugs List <koha-bugs>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: gmcharlt, kyle.m.hall
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Lucas Gass (lukeg) 2021-12-16 20:53:05 UTC
To recreate:

1.  Have AutoRenewalNotices set to "according to patron messaging preferences"
2.  Make some patron checkouts eligible from auto_renewal 
3.  Turn on SMS and Digest only Auto renewal messaging prefs for that patron
4. By default there is no SMS template for AUTO_RENEWALS_DGST, leave it that way
5. Run automatic_renewal.pl

When it hits that patron you'll see:

No circulation AUTO_RENEWALS_DGST letter transported by sms at /kohadevbox/koha/C4/Letters.pm line 633.
no letter of type 'AUTO_RENEWALS_DGST' found for borrowernumber 5. Please see sample_notices.sql at /kohadevbox/koha/misc/cronjobs/automatic_renewals.pl line 304.
Can't use string ("1") as a HASH ref while "strict refs" in use at /kohadevbox/koha/C4/Letters.pm line 947.


The job dies at this point. It would be better if it just skipped sending this patron a notice and carried on.
Comment 1 Lucas Gass (lukeg) 2022-03-24 14:58:11 UTC

*** This bug has been marked as a duplicate of bug 30354 ***