Summary: | If serials_stats.pl returns no results dataTables get angry | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Reports | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | andrew, kyle, nugged, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.05.00,21.11.02,21.05.08
|
Circulation function: | |
Attachments: |
Bug 29729: Build a tr for each subscription
Bug 29729: Build a tr for each subscription Bug 29729: Build a tr for each subscription |
Description
Lucas Gass (lukeg)
2021-12-17 21:06:42 UTC
Created attachment 128686 [details] [review] Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Created attachment 128687 [details] [review] Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Created attachment 128699 [details] [review] Bug 29729: Build a tr for each subscription To test: 1 To to Reports > Serials > Serials subscriptions and run the report while selecting a branch without subscriptions. 2 Notice console error 3 If you run the report for a branch WITH subscriptions it works just fine. 4 Apply patch 5 Do 1 again, no console error and show no see 'No entries to show' 6 Make sure it also works when you have a few subscriptions for a branch as well Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Nice catch :) Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.02 Pushed to 21.05.x for 21.05.08 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |