| Summary: | Check alert in cataloguing authorities should be a static message | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
| Component: | Cataloging | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | m.de.rooy, matt.blenkinsop, phil |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: |
This patch changes the way error form validation error messages are displayed when editing authority records. Instead of a JavaScript alert, errors are now shown on the page itself, with links in the message to take you to the corresponding field. A new "Errors" button in the toolbar allows the user to jump back to the list of errors for easy reference.
|
Version(s) released in: |
23.11.00,23.05.02
|
| Circulation function: | |||
| Bug Depends on: | 24415 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29732: Check alert in cataloguing authorities should be a static message
Bug 29732: Check alert in cataloguing authorities should be a static message Bug 29732: Check alert in cataloguing authorities should be a static message |
||
|
Description
Katrin Fischer
2021-12-19 13:30:53 UTC
Created attachment 152911 [details] [review] Bug 29732: Check alert in cataloguing authorities should be a static message This patch modifies the authority record editor so that form validation errors are collected in a static "dialog" at the top of the page instead of showing in a transient JavaScript alert. The text of the message is roughly the same as it was in the alert, and links have been added so that the user can click to jump directly to the field referenced. If the user scrolls down away from the static error message, a button appears in the floating toolbar to jump back to the message. - Go to Authorities and create a new authority record using a framework which has multiple mandatory fields defined (e.g. an unmodified default framework) - Without entering anything in mandatory fields, click the "Save" button. - You should see a message box appear at the top of the page. - It should list each missing mandatory subfield and tag, each with a "Go to field" link next to it. - Clicking the "Go to field" link should switch you to the correct tab and scroll the mandatory field into view. - When you have scrolled down far enough for the error messages to be offscreen, an "Errors" button should appear in the floating toolbar. Clicking it should scroll the box back into view. - If you fix some but not all of the missing mandatory fields the message should update with only the current issues. - Confirm that the record saves when all issues are resolved. Created attachment 152922 [details] [review] Bug 29732: Check alert in cataloguing authorities should be a static message This patch modifies the authority record editor so that form validation errors are collected in a static "dialog" at the top of the page instead of showing in a transient JavaScript alert. The text of the message is roughly the same as it was in the alert, and links have been added so that the user can click to jump directly to the field referenced. If the user scrolls down away from the static error message, a button appears in the floating toolbar to jump back to the message. - Go to Authorities and create a new authority record using a framework which has multiple mandatory fields defined (e.g. an unmodified default framework) - Without entering anything in mandatory fields, click the "Save" button. - You should see a message box appear at the top of the page. - It should list each missing mandatory subfield and tag, each with a "Go to field" link next to it. - Clicking the "Go to field" link should switch you to the correct tab and scroll the mandatory field into view. - When you have scrolled down far enough for the error messages to be offscreen, an "Errors" button should appear in the floating toolbar. Clicking it should scroll the box back into view. - If you fix some but not all of the missing mandatory fields the message should update with only the current issues. - Confirm that the record saves when all issues are resolved. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Not this bug, but at some point we should do something about the weirdness (shared with the biblio editor) of having mandatory fields that have default data, so that instead of saying "000 is not filled in" and when you go there it *is* filled in, we say something like "has been filled with default data". Created attachment 153520 [details] [review] Bug 29732: Check alert in cataloguing authorities should be a static message This patch modifies the authority record editor so that form validation errors are collected in a static "dialog" at the top of the page instead of showing in a transient JavaScript alert. The text of the message is roughly the same as it was in the alert, and links have been added so that the user can click to jump directly to the field referenced. If the user scrolls down away from the static error message, a button appears in the floating toolbar to jump back to the message. - Go to Authorities and create a new authority record using a framework which has multiple mandatory fields defined (e.g. an unmodified default framework) - Without entering anything in mandatory fields, click the "Save" button. - You should see a message box appear at the top of the page. - It should list each missing mandatory subfield and tag, each with a "Go to field" link next to it. - Clicking the "Go to field" link should switch you to the correct tab and scroll the mandatory field into view. - When you have scrolled down far enough for the error messages to be offscreen, an "Errors" button should appear in the floating toolbar. Clicking it should scroll the box back into view. - If you fix some but not all of the missing mandatory fields the message should update with only the current issues. - Confirm that the record saves when all issues are resolved. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 23.11. Nice work everyone, thanks! Thanks for all the hard work! Pushed to 23.05.x for the next release Enhancement - not backporting to 22.11.x Nice work everyone! |