|
Description
Katrin Fischer
2021-12-19 13:50:17 UTC
*** Bug 30977 has been marked as a duplicate of this bug. *** Looks like late 2021 me already had the same idea :) Created attachment 180605 [details] [review] Bug 29733: MARC21: Link 7xx linking fields to marc21_linking_section.pl value builder When creating an analytical record from scratch and filling the 773 field with marc21_linking_section.pl plugin, the information put in field 773 is very basic, incomplete, sometimes buggy ($9, $0). Test plan ========= 1. Configure a MARC bibliographic framework: enable essential subfields in 773: 7, a, t, b, d, g, k, x, z, w (check the Editor checkbox), put them in this order, and chose plugin marc21_linking_section.pl for 773 $t. 2. Start creating a new record and go to 773 $t. Activate the plugin to find the a record to become the host record (perform a search for 'Linux kernel development'). Note the content of the 773 field. 3. Apply the patch, restart plack etc. 4. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7. Additionally, commented code has been removed and check/variable initialization added to get rid of warnings in log. Created attachment 180607 [details] [review] Bug 29733: MARC21: Link 7xx linking fields to marc21_linking_section.pl value builder When creating an analytical record from scratch and filling the 773 field with marc21_linking_section.pl plugin, the information put in field 773 is very basic, incomplete, sometimes buggy ($9, $0). Test plan ========= 1. Configure a MARC bibliographic framework: enable essential subfields in 773: 7, a, t, b, d, g, k, x, z, w (check the Editor checkbox), put them in this order, and chose plugin marc21_linking_section.pl for 773 $t. 2. Start creating a new record and go to 773 $t. Activate the plugin to find the a record to become the host record (perform a search for 'Linux kernel development'). Note the content of the 773 field. 3. Apply the patch, restart plack etc. 4. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7. Additionally, commented code has been removed and check/variable initialization added to get rid of warnings in log. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> It works as described in test plan. Maybe one thing to improve (similarly like in Bug 39545 ?) -- adding multiple ISBN to subfield $z. Now only last one is included. Created attachment 189071 [details] [review] Bug 29733: MARC21: Link 7xx linking fields to marc21_linking_section.pl value builder When creating an analytical record from scratch and filling the 773 field with marc21_linking_section.pl plugin, the information put in field 773 is very basic, incomplete, sometimes buggy ($9, $0). Test plan ========= 1. Configure a MARC bibliographic framework: enable essential subfields in 773: 7, a, t, b, d, g, k, x, z, w (check the Editor checkbox), put them in this order, and chose plugin marc21_linking_section.pl for 773 $t. 2. Start creating a new record and go to 773 $t. Activate the plugin to find the a record to become the host record (perform a search for 'Linux kernel development'). Note the content of the 773 field. 3. Apply the patch, restart plack etc. 4. Repeat p. 2.-3. See that the generated 773 field contains now much more information, including 773 $7. Additionally, commented code has been removed and check/variable initialization added to get rid of warnings in log. Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Nice work everyone! Pushed to main for 25.11 |