| Summary: | Remove flatpickr instantiations from .js files | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Templates | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, david, fridolin.somers, kyle, nugged |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29552 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.02
|
|
| Circulation function: | |||
| Bug Depends on: | 29394 | ||
| Bug Blocks: | 29239 | ||
| Attachments: |
Bug 29735: Remove flatpickr init from categories.js and holds.js
Bug 29735: Remove flatpickr init from categories.js and holds.js Bug 29735: Remove flatpickr init from categories.js and holds.js Bug 29735: Fix flatpickr init from circulation.tt |
||
|
Description
Jonathan Druart
2021-12-20 10:46:06 UTC
Created attachment 128733 [details] [review] Bug 29735: Remove flatpickr init from categories.js and holds.js Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled Created attachment 128765 [details] [review] Bug 29735: Remove flatpickr init from categories.js and holds.js Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled Signed-off-by: David Nind <david@davidnind.com> Testing notes (koha-testing-docker): 1. Apply after applying bug 29552 so that options not selectable are greyed out. Created attachment 128805 [details] [review] Bug 29735: Remove flatpickr init from categories.js and holds.js Same as bug 29394, we want the flatpickr instanciations be done at the same place, from calendar.inc. That way they will all behave identically. Test plan: Edit a patron category and confirm that the "until date" calendar has the "yesterday" and "today" dates disabled Place a hold on an item, go to the patron detail page, click the "holds" tab, suspend. That should trigger a modal that will display a calendar with "yesterday" and "today" dates disabled Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.02 I found that string:
[% INCLUDE 'calendar.inc' %]
reordered in:
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt (-1 / +1 lines)
koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt (-1 / +1 lines)
but seems the same reordering is needed in:
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
because when I pressing the "suspend" button on:
.../cgi-bin/koha/circ/circulation.pl?borrowernumber=ANY_ONE_WITH_HOLD
opens a modal popup without flatpickr (but there's flatpicker for the first two mentioned above templates).
Created attachment 129684 [details] [review] Bug 29735: Fix flatpickr init from circulation.tt Missing dependency, not backported to 21.05 (In reply to Kyle M Hall from comment #6) > Pushed to 21.11.x for 21.11.02 Kyle, this post-publishing patch probably lost: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29735#c8 from just-happened 21.11.03, so maybe to include it to 21.11.04? Second patch pushed to master : 177f938af0 Bug 29735: Fix flatpickr init from circulation.tt I see second patch is in 21.11.x 9f7e99b8c4 Bug 29735: Fix flatpickr init from circulation.tt Missing dependency, not backported to 21.05 |