| Summary: | Cannot suspend holds | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Hold requests | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | andrew, gmcharlt, kyle, tomascohen |
| Version: | unspecified | Keywords: | regression |
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.02
|
|
| Circulation function: | |||
| Attachments: |
Bug 29737: Fix suspend from hold list
Bug 29737: Remove some unecessary parameters Bug 29737: Fix suspend from hold list Bug 29737: Remove some unecessary parameters Bug 29737: Fix suspend from hold list Bug 29737: Remove some unecessary parameters |
||
|
Description
Jonathan Druart
2021-12-20 12:49:36 UTC
Created attachment 128754 [details] [review] Bug 29737: Fix suspend from hold list From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Created attachment 128755 [details] [review] Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. This is a regression but no idea when it has been introduced! Created attachment 128780 [details] [review] Bug 29737: Fix suspend from hold list From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david@davidnind.com> Created attachment 128781 [details] [review] Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david@davidnind.com> Created attachment 128803 [details] [review] Bug 29737: Fix suspend from hold list From holds list of a bibliographic record, the "unsuspend" button does not work as expected. The form is submitted but the suspension is still there. There are 3 requests, 2 GET and 1 POST. One of the GET is rejected by Firefox (NS_BINDING_ABORTED) Test plan: Place some items on hold, play with suspend/unsuspend from the hold list /cgi-bin/koha/reserve/request.pl?biblionumber=XX Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 128804 [details] [review] Bug 29737: Remove some unecessary parameters We don't need them. We could also remove the biblionumber but it requires change to the controller I'd prefer to not do now. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.02 Cannot recreate issue on 21.05.x. Not backporting. Please request if needed. |