Description
Jérémy Breuillard
2021-12-23 13:22:45 UTC
*** Bug 29766 has been marked as a duplicate of this bug. *** Created attachment 128884 [details] [review] MT 28590: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> Created attachment 128885 [details] [review] Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> QA script reports the following errors: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 1651) FAIL reports/guided_reports.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 903) Created attachment 128886 [details] [review] Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> Created attachment 128889 [details] [review] Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> Created attachment 129043 [details] [review] Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Hi Jeremy, please don't forget to assign any bugs you are working on/plan to work on to yourself :) Created attachment 129979 [details] [review] Bug 29767: SQL Koha reports and variable of database table << name|table_name>> 'Insert runtime parameter' has now more options for the SQL reports : 'cash register', 'debit types' and 'credit types' Test plan: 1)Home > Reports > Create from SQL 2)Click on 'Insert runtime parameter' and notice the current options 3)Apply patch and repeat 2) 4)New parameters are now available 5)A simple SQL request to try 'credit_types' option : SELECT * FROM account_credit_types WHERE code = <<Credit types|credit_types>> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=29796 Created attachment 129980 [details] [review] Bug 29767: (QA follow-up) Make singular/plural forms consistent Just fixes some strings to match with the other runtime parameters in their singular and plural forms. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=29796 Please add a nice release note ;) Pushed to master for 22.05, thanks to everybody involved [U+1F984] |