Bug 29789

Summary: Unused $error in cataloguing/additem.pl
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Kyle M Hall <kyle>
Severity: minor    
Priority: P5 - low CC: andrewfh, kyle, tomascohen, victor
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00,21.11.02,21.05.09
Bug Depends on:    
Bug Blocks: 29788    
Attachments: Bug 29789: Remove unused $error from cataloguing/additem.pl
Bug 29789: Remove unused $error from cataloguing/additem.pl
Bug 29789: Remove unused $error from cataloguing/additem.pl

Description Jonathan Druart 2022-01-04 14:41:11 UTC
my $error        = $input->param('error');

It should be removed as $error is used later but not related to this variable.
Comment 1 Jonathan Druart 2022-01-04 14:42:02 UTC
Created attachment 128991 [details] [review]
Bug 29789: Remove unused $error from cataloguing/additem.pl

my $error        = $input->param('error');

It should be removed as $error is used later but not related to this variable.
Comment 2 Tomás Cohen Arazi 2022-01-04 15:44:37 UTC
Created attachment 129005 [details] [review]
Bug 29789: Remove unused $error from cataloguing/additem.pl

my $error        = $input->param('error');

It should be removed as $error is used later but not related to this variable.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 3 Kyle M Hall 2022-01-07 13:47:27 UTC
Created attachment 129164 [details] [review]
Bug 29789: Remove unused $error from cataloguing/additem.pl

my $error        = $input->param('error');

It should be removed as $error is used later but not related to this variable.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 4 Fridolin Somers 2022-01-11 22:51:53 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄
Comment 5 Kyle M Hall 2022-01-14 14:03:23 UTC
Pushed to 21.11.x for 21.11.02
Comment 6 Andrew Fuerste-Henry 2022-01-21 17:48:23 UTC
Pushed to 21.05.x for 21.05.09
Comment 7 Victor Grousset/tuxayo 2022-02-07 18:54:37 UTC
Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed.