| Summary: | KohaOpacLanguage cookie should set the secure flag if using HTTPS | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Kyle M Hall (khall) <kyle> |
| Component: | Architecture, internals, and plumbing | Assignee: | Kyle M Hall (khall) <kyle> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | nick, wizzyrea |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25360 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Attachments: |
Bug 29791 - KohaOpacLanguage cookie should set the secure flag if using https
Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https Bug 29791: (follow-up) Add missing comma in previous line Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https Bug 29791: (follow-up) Add missing comma in previous line |
||
|
Description
Kyle M Hall (khall)
2022-01-04 15:23:53 UTC
Created attachment 129004 [details] [review] Bug 29791 - KohaOpacLanguage cookie should set the secure flag if using https To test, the headers should have value set-cookie: secure; for the language cookie, when the site is using https. Created attachment 129223 [details] [review] Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https To test, the headers should have value set-cookie: secure; for the language cookie, when the site is using https. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 129224 [details] [review] Bug 29791: (follow-up) Add missing comma in previous line Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> I couldn't test with https, but have verified the cookie is set correctly with my follow-up patch on http. Created attachment 132009 [details] [review] Bug 29791: KohaOpacLanguage cookie should set the secure flag if using https To test, the headers should have value set-cookie: secure; for the language cookie, when the site is using https. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 132010 [details] [review] Bug 29791: (follow-up) Add missing comma in previous line Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |