| Summary: | Background job detail for batch delete items not listing the itemnumbers | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | andrew, fridolin.somers, kyle, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03
|
|
| Circulation function: | |||
| Bug Depends on: | 28445 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29797: Fix display of itemnumbers on the background job detail view
Bug 29797: Fix display of itemnumbers on the background job detail view Bug 29797: Fix display of itemnumbers on the background job detail view Bug 29797: Fix display of itemnumbers on the background job detail view |
||
|
Description
Jonathan Druart
2022-01-05 09:38:20 UTC
Created attachment 129019 [details] [review] Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Created attachment 129588 [details] [review] Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 129589 [details] [review] Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Also add a space character between itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> > Also add a space character between itemnumbers.
I tested with 2 items impossible to delete and notices that itemnumbers do not have a separator.
Very small fix so I made it will signing.
BTW :
Do we even need this itemnumber list ?
It is not clear for user that those are itemnumbers and not barcodes.
We have a message for each item in "Detailed messages".
Created attachment 129599 [details] [review] Bug 29797: Fix display of itemnumbers on the background job detail view If some items have not been deleted, the detail view of the background job will display "1 item(s) could not be deleted: ", without the list of itemnumbers. Also add a space character between itemnumbers. Test plan: 1. Check an item out 2. Use the batch delete items tool to delete the item that is checked out and another one. 3. On the confirmation view, use the dev tool of your browser to remove the "disabled" property of the disabled checkbox and select both items. 4. Submit 5. Go to the detail view of the background job and confirm that you see the itemnumber of the item that has failed to be deleted Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Good catch, works as described now. I agree, itemnumbers may not be the best thing to output.. but trying to output something more meaningful to the end-user may well result in gaps.. itemnumber is definitively going to be defined. Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.03 Missing dependency, not backported to 21.05 |