Bug 29868

Summary: Add Koha::Old::Hold->anonymize
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi <tomascohen>
Status: RESOLVED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: enhancement    
Priority: P5 - low CC: kyle, martin.renvoize
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Bug Depends on: 29869    
Bug Blocks: 29525    
Attachments: Bug 29868: Add Koha::Old::Hold->anonymize
Bug 29868: Add Koha::Old::Hold->anonymize
Bug 29868: Add Koha::Old::Hold->anonymize
Bug 29868: Add Koha::Old::Hold->anonymize
Bug 29868: Add Koha::Old::Hold->anonymize

Description Tomás Cohen Arazi 2022-01-12 19:23:12 UTC
Found the need to anonymize from Koha::Hold->cancel, and in this case using an iterator would be overkill as I already have the Koha::Old::Hold object in place as the return value from $self->_move_to_old...
Comment 1 Tomás Cohen Arazi 2022-01-12 19:25:23 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2022-01-12 19:27:47 UTC Comment hidden (obsolete)
Comment 3 Tomás Cohen Arazi 2022-01-13 14:56:09 UTC
Created attachment 129410 [details] [review]
Bug 29868: Add Koha::Old::Hold->anonymize

This patch introduces a new method in Koha::Old::Hold. The method is
fully covered by tests.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Old/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 4 Tomás Cohen Arazi 2022-01-13 14:57:05 UTC
Resubmitted and made it dependent on bug 29869 as they both add tests to Koha/Hold.t and the count is always gonna be a problem :-D
Comment 5 Andrew Fuerste-Henry 2022-01-13 16:56:18 UTC
Created attachment 129423 [details] [review]
Bug 29868: Add Koha::Old::Hold->anonymize

This patch introduces a new method in Koha::Old::Hold. The method is
fully covered by tests.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Old/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Comment 6 Martin Renvoize 2022-01-17 17:11:52 UTC
Created attachment 129541 [details] [review]
Bug 29868: Add Koha::Old::Hold->anonymize

This patch introduces a new method in Koha::Old::Hold. The method is
fully covered by tests.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Old/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 7 Martin Renvoize 2022-01-17 17:12:16 UTC
Tests passing, QA script happy.. Code all makes sense.

Passing QA
Comment 8 Fridolin Somers 2022-02-11 00:38:08 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄