Bug 29871

Summary: Remove marcflavour param in Koha::Biblio->get_marc_notes
Product: Koha Reporter: Fridolin Somers <fridolin.somers>
Component: Architecture, internals, and plumbingAssignee: Fridolin Somers <fridolin.somers>
Status: CLOSED FIXED QA Contact: Martin Renvoize <martin.renvoize>
Severity: normal    
Priority: P5 - low CC: david, lucas, martin.renvoize
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.11.00, 22.05.03
Bug Depends on: 27268    
Bug Blocks: 29652    
Attachments: Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes
Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes
Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes

Description Fridolin Somers 2022-01-13 07:13:19 UTC
Remove marcflavour param in Koha::Biblio->get_marc_*
We use system preference.
Comment 1 Fridolin Somers 2022-01-13 07:20:48 UTC Comment hidden (obsolete)
Comment 2 Fridolin Somers 2022-01-13 07:21:26 UTC
Created attachment 129379 [details] [review]
Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes

Test plan :
Display a biblio record with some MARC notes in details page and basket,
OPAC and staff
Run prove t/db_dependent/Koha/Biblio.t
Comment 3 David Nind 2022-04-30 22:21:30 UTC
Patch no longer applies 8-(..

git bz apply 29871

Bug 29871 - Remove marcflavour param in Koha::Biblio->get_marc_notes

129379 - Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes
Using index info to reconstruct a base tree...
M	Koha/Biblio.pm
M	basket/basket.pl
M	catalogue/detail.pl
M	opac/opac-basket.pl
M	opac/opac-detail.pl
M	t/db_dependent/Koha/Biblio.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Koha/Biblio.t
Auto-merging opac/opac-detail.pl
Auto-merging opac/opac-basket.pl
Auto-merging catalogue/detail.pl
CONFLICT (content): Merge conflict in catalogue/detail.pl
Auto-merging basket/basket.pl
Auto-merging Koha/Biblio.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes
Comment 4 Martin Renvoize 2022-05-25 11:17:17 UTC
Created attachment 135337 [details] [review]
Bug 29871: Remove marcflavour param in Koha::Biblio->get_marc_notes

Test plan :
Display a biblio record with some MARC notes in details page and basket,
OPAC and staff
Run prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2022-05-25 11:18:09 UTC
Trivial and sensible fix..

Straight QAing.. Passed.
Comment 6 Tomás Cohen Arazi 2022-06-06 17:33:09 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 7 Lucas Gass 2022-07-12 15:58:05 UTC
Backported to 22.05.x for 22.05.03