| Summary: | Remove unused method C4::SIP::ILS::Item::fill_reserve | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | SIP2 | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Kyle M Hall (khall) <kyle> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle, martin.renvoize |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
| Circulation function: | |||
| Bug Depends on: | 29869 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve
Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve |
||
|
Description
Tomás Cohen Arazi (tcohen)
2022-01-13 12:47:45 UTC
Created attachment 129399 [details] [review] Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Created attachment 129422 [details] [review] Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> I agree... I can't find any uses of this method. I believe we handle all this inside the relevant Koha:: methods that trigger fulfilment now instead. Signing off Created attachment 129601 [details] [review] Bug 29874: Remove unused method C4::SIP::ILS::Item::fill_reserve This patch removes the unused method. Likely a leftover from ancient ages. AddIssue already fills the hold and is called in the Checkout.pm library. To test: 1. Run: $ git grep fill_reserve => FAIL: Notice it is only mentioned in the line that defines it 2. Apply this patch 3. Repeat 1 => SUCCESS: Removed. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |