Bug 29876

Summary: Style report id in report results heading
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: fridolin.somers, kyle, lucas
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Trivial patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
22.05.00
Bug Depends on: 24834    
Bug Blocks:    
Attachments: Screenshot showing the updated interface
Bug 29876: Style report id in report results heading
Bug 29876: Style report id in report results heading
Bug 29876: Style report id in report results heading
Bug 29876: (follow-up) Change "Report number" to "Report ID"

Description Owen Leonard 2022-01-13 14:43:18 UTC
Created attachment 129403 [details]
Screenshot showing the updated interface

I find the inclusion of the report id in the heading of the SQL report results page to be confusing because it can look like it is showing the number of results. I think adding some style to it would help.
Comment 1 Owen Leonard 2022-01-13 14:48:41 UTC
Created attachment 129404 [details] [review]
Bug 29876: Style report id in report results heading

This patch makes minor changes to the template and adds some CSS to
style the report id portion of the page heading.

To test, apply the patch and go to Reports -> Saved SQL reports.

- Run any report.
- On the results page, confirm that the report id portion of the page
  heading is styled and labeled "Report number."
Comment 2 Lucas Gass 2022-01-13 17:58:47 UTC
Created attachment 129430 [details] [review]
Bug 29876: Style report id in report results heading

This patch makes minor changes to the template and adds some CSS to
style the report id portion of the page heading.

To test, apply the patch and go to Reports -> Saved SQL reports.

- Run any report.
- On the results page, confirm that the report id portion of the page
  heading is styled and labeled "Report number."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Lucas Gass 2022-01-13 17:59:48 UTC
This is makes it much more clear, thanks!
Comment 4 Katrin Fischer 2022-01-30 00:04:13 UTC
Created attachment 129973 [details] [review]
Bug 29876: Style report id in report results heading

This patch makes minor changes to the template and adds some CSS to
style the report id portion of the page heading.

To test, apply the patch and go to Reports -> Saved SQL reports.

- Run any report.
- On the results page, confirm that the report id portion of the page
  heading is styled and labeled "Report number."

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2022-01-30 00:05:22 UTC
Only a small thing: Should we make this read Report ID to match the label on the saved reports table?
Comment 6 Fridolin Somers 2022-02-10 08:10:31 UTC
(In reply to Katrin Fischer from comment #5)
> Only a small thing: Should we make this read Report ID to match the label on
> the saved reports table?

+1
Comment 7 Owen Leonard 2022-02-14 19:03:31 UTC
Created attachment 130567 [details] [review]
Bug 29876: (follow-up) Change "Report number" to "Report ID"

This makes is consistent with the display of saved reports where the
number is shown in an "ID" column.
Comment 8 Fridolin Somers 2022-02-23 08:28:14 UTC
Pushed to master for 22.05, thanks to everybody involved 🦄