Summary: | Style report id in report results heading | ||
---|---|---|---|
Product: | Koha | Reporter: | Owen Leonard <oleonard> |
Component: | Templates | Assignee: | Owen Leonard <oleonard> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, lucas |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00
|
|
Circulation function: | |||
Bug Depends on: | 24834 | ||
Bug Blocks: | |||
Attachments: |
Screenshot showing the updated interface
Bug 29876: Style report id in report results heading Bug 29876: Style report id in report results heading Bug 29876: Style report id in report results heading Bug 29876: (follow-up) Change "Report number" to "Report ID" |
Created attachment 129404 [details] [review] Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." Created attachment 129430 [details] [review] Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> This is makes it much more clear, thanks! Created attachment 129973 [details] [review] Bug 29876: Style report id in report results heading This patch makes minor changes to the template and adds some CSS to style the report id portion of the page heading. To test, apply the patch and go to Reports -> Saved SQL reports. - Run any report. - On the results page, confirm that the report id portion of the page heading is styled and labeled "Report number." Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Only a small thing: Should we make this read Report ID to match the label on the saved reports table? (In reply to Katrin Fischer from comment #5) > Only a small thing: Should we make this read Report ID to match the label on > the saved reports table? +1 Created attachment 130567 [details] [review] Bug 29876: (follow-up) Change "Report number" to "Report ID" This makes is consistent with the display of saved reports where the number is shown in an "ID" column. Pushed to master for 22.05, thanks to everybody involved [U+1F984] |
Created attachment 129403 [details] Screenshot showing the updated interface I find the inclusion of the report id in the heading of the SQL report results page to be confusing because it can look like it is showing the number of results. I think adding some style to it would help.