Bug 29879

Summary: Make sure objects moved to old_* is not tried to be saved again
Product: Koha Reporter: Tomás Cohen Arazi <tomascohen>
Component: Architecture, internals, and plumbingAssignee: Tomás Cohen Arazi <tomascohen>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low    
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 29525    
Bug Blocks:    

Description Tomás Cohen Arazi 2022-01-13 18:13:44 UTC
When a checkout or a hold is completed, Koha moves the issues/reserves row to their old_* counterpart. We are leaning towards chaining calls to simplify code, but calling methods like Koha::Hold->cancel or Koha::Hold->fill should somehow mark the current object so trying to store it by mistake should raise an exception.