| Summary: | Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Andrii Nugged <nugged> |
| Component: | Acquisitions | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | andrew, kyle, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03,21.05.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 29895: Fix 'add multiple items' button on neworderempty
Bug 29895: Fix 'add multiple items' button on neworderempty Bug 29895: Fix 'add multiple items' button on neworderempty |
||
|
Description
Andrii Nugged
2022-01-17 14:10:48 UTC
Also there typo with quoting in the same additem.js file, notice:
name=buttonAddMulti"
in line 187:
+ '<input type="button" class="addItemControl" name=buttonAddMulti" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,\'' + unique_item_fields + '\')" value="' + __("Add") + '" />'
Created attachment 129533 [details] [review] Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. Created attachment 129572 [details] [review] Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Created attachment 130023 [details] [review] Bug 29895: Fix 'add multiple items' button on neworderempty Button [Add multiple items] stops responding when it's pressed and some multiple items added to basket It has a "visibility: hidden" we are trying to remove setting "display: inline" This is pretty ugly and certainly does not clean the code, but it's too messy and this patch fixes the problem easily. Test plan: Add a new order Click "Add multiple items", enter "2", click "Add". Confirm that you can use the "Add multiple items" again. Signed-off-by: Samu Heiskanen <samu.heiskanen@hypernova.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.03 Pushed to 21.05.x for 21.05.11 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |