Summary: | Add ability to disable hold capture via SIP checkin | ||
---|---|---|---|
Product: | Koha | Reporter: | Martin Renvoize (ashimema) <martin.renvoize> |
Component: | SIP2 | Assignee: | Martin Renvoize (ashimema) <martin.renvoize> |
Status: | CLOSED FIXED | QA Contact: | Tomás Cohen Arazi (tcohen) <tomascohen> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, kyle, sally.healey, tomascohen |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: |
This enhancement adds a new `holds_get_captured` configuration option to SIP accounts.
The new option defaults to enabled, as has been the case since bug 3638 was pushed. However, it allows for disabling hold capture so that items are not automatically assigned to holds at SIP check-in; The alerts messages will continue to show, however, to allow items to be put to one side and then captured by a subsequent staff check-in.
|
Version(s) released in: |
22.05.00
|
Circulation function: | |||
Attachments: |
Bug 29936: Add unit tests
Bug 29936: Add holds_get_captured option to sip config Bug 29936: Add unit tests Bug 29936: Add holds_get_captured option to sip config Bug 29936: Add unit tests Bug 29936: Add holds_get_captured option to sip config Bug 29936: Add unit tests Bug 29936: Add holds_get_captured option to sip config Bug 29936: (follow-up) Remove useless warining |
Description
Martin Renvoize (ashimema)
2022-01-25 11:02:43 UTC
Hm, isn't that what HoldsNeedProcessingSIP does? Interesting.. very nearly. I had entirely forgotten about that new preference.. however, it doesn't appear to resolve the transfers issue.. i.e. the hold is still captured, though it's marked as processing.. in the SIP code itself, the item may then be set to in transfer.. I really wish Holds and Transfers were better tied together.. it's somewhat mad that a hold can be set to in transfer without it actually triggering a transfer (in code) and thus you have to follow any call to ModReserveAffect with a Transfer anyway. In fact.. our customer doesn't want SIP returns to result in holds captured at all in my understanding. They often have patrons just ignore the self check prompt to put the item into the exceptions bin and thus items are reshelved and not actually captured for the hold at all.. SO what they want is for the message to appear just in case the patron pays attention and thus puts the item in the exceptions bin.. but for the actual capture to require a staff check-in as the next step. Created attachment 131555 [details] [review] Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Created attachment 131556 [details] [review] Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Thanks for this, Martin - we have this running on our live system and all is working well. Happy for my sign off to be added. Created attachment 131575 [details] [review] Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 131576 [details] [review] Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Excellent, thanks for confirming Sally. Signoff line added :) Created attachment 131577 [details] [review] Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 131578 [details] [review] Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Created attachment 133763 [details] [review] Bug 29936: Add unit tests This patch adds a unit test for the new functionality introduced with holds_get_captured allowing for holds to still be highlighted to patrons at checkin but not mark them as found/transfered in the system. Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 133764 [details] [review] Bug 29936: Add holds_get_captured option to sip config This patch adds a new option to the SIP config, allowing for hold capture to be disabled on difference devices. We still notice the hold and alert the user, but we do not trigger the update in the system to mark the hold as found (waiting, processing or in transit). Sponsored-by: Cheshire Libraries Shared Services Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 133765 [details] [review] Bug 29936: (follow-up) Remove useless warining Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |