| Summary: | Phase out jquery.cookie.js in the OPAC | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | jonathan.druart, kyle, m.de.rooy, testopia |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
| Circulation function: | |||
| Bug Depends on: | 11873 | ||
| Bug Blocks: | 26019, 27750 | ||
| Attachments: |
Bug 29940: Phase out jquery.cookie.js in the OPAC
Bug 29940: Phase out jquery.cookie.js in the OPAC Bug 29940: Phase out jquery.cookie.js in the OPAC Bug 29940: Don't surround value by quote Bug 29940: Phase out jquery.cookie.js in the OPAC Bug 29940: Don't surround value by quote |
||
|
Description
Owen Leonard
2022-01-25 12:49:43 UTC
Created attachment 129749 [details] [review] Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. Same as bug 11873, I would remove the non-minified version. Created attachment 129835 [details] [review] Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. Created attachment 129890 [details] [review] Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 129891 [details] [review] Bug 29940: Don't surround value by quote Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Consider my stamp a PQA if someone else tests this. Created attachment 131838 [details] [review] Bug 29940: Phase out jquery.cookie.js in the OPAC This patch replaces the use of jquery.cookie.js in the OPAC with the newer js-cookie plugin. The patch adds the latest version of the js-cookie library and removes the old jquery.cookie plugin. To test, apply the patch and go to the advanced search page in the OPAC. - Perform a search using a number of different limits and settings, e.g. keyword, item type, and sort-by. - On the search results page you should see at the top of the results list a link to "Return to the last advanced search." - The link should take you back to the advanced search page with all the same settings filled into the form. - A search with the "More options" view enabled in the advanced search form should result in a link which returns to the "More options" view. - Searching via the "quick search" form at the top of the page should clear the cookies which were set in order to remember the advanced search. See https://developer.mozilla.org/en-US/docs/Tools/Storage_Inspector for information on viewing your browser's stored cookies. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 131839 [details] [review] Bug 29940: Don't surround value by quote Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Jonathan Druart from comment #6) > Consider my stamp a PQA if someone else tests this. Haha Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.05 |