Summary: | Horizontal scroll bar in acquisition z39.50 search should always show | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Acquisitions | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | arthur.suzuki, jonathan.druart, kelly, martin.renvoize, tomascohen, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19865 | ||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | Trivial patch | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: |
22.11.00, 22.05.01, 21.11.07
|
Circulation function: | |
Attachments: |
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl
Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl |
Description
Lucas Gass (lukeg)
2022-01-27 16:36:37 UTC
Created attachment 129914 [details] [review] Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl To test: 1. In Acquisitions make a basket and add something "From an external source" 2. Search for a title and click on the 'MARC' button, make sure the MARC prview is both tall and wide. 3. You will not see the horizontal scroll bar unless you scroll all the way to the bottom of the preview. 4. Apply patch. 5. Try steps 1 & 2 again, this time you should see the horizontal scroll bar as soon as the MARC prveiw loads. Note: I put the CSS on multiple lines for better readability Created attachment 135459 [details] [review] Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl To test: 1. In Acquisitions make a basket and add something "From an external source" 2. Search for a title and click on the 'MARC' button, make sure the MARC prview is both tall and wide. 3. You will not see the horizontal scroll bar unless you scroll all the way to the bottom of the preview. 4. Apply patch. 5. Try steps 1 & 2 again, this time you should see the horizontal scroll bar as soon as the MARC prveiw loads. Note: I put the CSS on multiple lines for better readability Signed-off-by: David Nind <david@davidnind.com> As you are reusing the same code as bug 19865 it would have been better to have the rules defined in a .css file. Created attachment 135477 [details] [review] Bug 29961: Make horizontal scroll bar always visible on acqui/z3950_search.pl To test: 1. In Acquisitions make a basket and add something "From an external source" 2. Search for a title and click on the 'MARC' button, make sure the MARC prview is both tall and wide. 3. You will not see the horizontal scroll bar unless you scroll all the way to the bottom of the preview. 4. Apply patch. 5. Try steps 1 & 2 again, this time you should see the horizontal scroll bar as soon as the MARC prveiw loads. Note: I put the CSS on multiple lines for better readability Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 22.11. Nice work everyone, thanks! Pushed to 22.05.x for 22.05.01 thx, this is pushed to 21.11.x for 21.11.07 Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. |