| Summary: | SCO Help page passes flags while not needing authentication | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Marcel de Rooy <m.de.rooy> |
| Component: | Architecture, internals, and plumbing | Assignee: | Marcel de Rooy <m.de.rooy> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | minor | ||
| Priority: | P5 - low | CC: | andrew, kyle, martin.renvoize, victor |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.03,21.05.11
|
|
| Circulation function: | |||
| Attachments: |
Bug 29966: Dont pass authnotrequired true and flags together
Bug 29966: Dont pass authnotrequired true and flags together |
||
Created attachment 129921 [details] [review] Bug 29966: Dont pass authnotrequired true and flags together Test plan: Logout in OPAC. Goto sco help page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Super trivial: self SO. Created attachment 130305 [details] [review] Bug 29966: Dont pass authnotrequired true and flags together Test plan: Logout in OPAC. Goto sco help page. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Trivial patch, no breakage, Passing QA Pushed to master for 22.05, thanks to everybody involved [U+1F984] Pushed to 21.11.x for 21.11.03 Pushed to 21.05.x for 21.05.11 Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. |
Help page passes this to get_template_and_user: authnotrequired => 1, flagsrequired => { self_check => "self_checkout_module" }, Which makes no sense.