Bug 29993

Summary:	Syndetics cover images do not display in browse shelf when scrolling from the first page
Product:	Koha	Reporter:	Lucy Vaux-Harvey <lucy.vaux-harvey>
Component:	OPAC	Assignee:	Lucas Gass (lukeg) <lucas>
Status:	RESOLVED FIXED	QA Contact:	Testopia <testopia>
Severity:	minor
Priority:	P5 - low	CC:	barbara.johnson, lucas, m.de.rooy, victor
Version:	Main
Hardware:	All
OS:	All
Change sponsored?:	---	Patch complexity:	Trivial patch
Documentation contact:		Documentation submission:
Text to go in the release notes:		Version(s) released in:	23.05.00,22.11.07
Circulation function:
Attachments:	Bug 29993: Show Syndetics covers when using shelfbrowser controls Bug 29993: Show Syndetics covers when using shelfbrowser controls Bug 29993: Show Syndetics covers when using shelfbrowser controls

Description Lucy Vaux-Harvey 2022-02-01 11:53:44 UTC

If you have SyndeticsCoverImages enabled the browse shelf display of cover images is broken.  The first loaded page of the shelf browse displays the images correctly but if you click Next or Previous to scroll to a new page the images do not display.  For example https://libsearch.aub.ac.uk/cgi-bin/koha/opac-detail.pl?biblionumber=1276&shelfbrowse_itemnumber=1539#holdings

Comment 1 Lucas Gass (lukeg) 2023-04-17 17:43:47 UTC

Created attachment 149765 [details] [review]
Bug 29993: Show Syndetics covers when using shelfbrowser controls

1. Have items that include itemcallnumber.
2. Enable OPACShelfBrowser.
3. Enable SyndeticsCoverImages and SyndeticsEnabled.
4. Go the an OPAC detail page and open the shelf browser.
5. Use the Next/Previous buttons.
6. Notice that no Syndetics images populate after using Next/Previous buttons.
7. Apply patch and try again, cover images for Syndetics should be generating.

Comment 2 ByWater Sandboxes 2023-04-17 17:47:28 UTC

Created attachment 149766 [details] [review]
Bug 29993: Show Syndetics covers when using shelfbrowser controls

1. Have items that include itemcallnumber.
2. Enable OPACShelfBrowser.
3. Enable SyndeticsCoverImages and SyndeticsEnabled.
4. Go the an OPAC detail page and open the shelf browser.
5. Use the Next/Previous buttons.
6. Notice that no Syndetics images populate after using Next/Previous buttons.
7. Apply patch and try again, cover images for Syndetics should be generating.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>

Comment 3 Barbara Johnson 2023-04-17 17:47:54 UTC

works like a charm

Comment 4 Victor Grousset/tuxayo 2023-05-13 02:55:16 UTC

test note: just put "test" in SyndeticsClientCode, it worked, that was total guesswork ^^"

Comment 5 Victor Grousset/tuxayo 2023-05-13 04:33:44 UTC

Created attachment 151164 [details] [review]
Bug 29993: Show Syndetics covers when using shelfbrowser controls

1. Have items that include itemcallnumber.
2. Enable OPACShelfBrowser.
3. Enable SyndeticsCoverImages and SyndeticsEnabled.
4. Go the an OPAC detail page and open the shelf browser.
5. Use the Next/Previous buttons.
6. Notice that no Syndetics images populate after using Next/Previous buttons.
7. Apply patch and try again, cover images for Syndetics should be generating.

Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov>
Rebased-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>

Comment 6 Victor Grousset/tuxayo 2023-05-13 04:34:03 UTC

Works, makes sense, QA script happy, code ok, passing QA :)

Comment 7 Tomás Cohen Arazi (tcohen) 2023-05-18 14:35:48 UTC

Pushed to master for 23.05.

Nice work everyone, thanks!

Comment 8 Matt Blenkinsop 2023-06-08 16:51:38 UTC

Nice work everyone!

Pushed to stable for 22.11.x