Description
Jérémy Breuillard
2022-02-07 10:48:40 UTC
Created attachment 130223 [details] [review] Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results Created attachment 130232 [details] [review] Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results Patch no longer applies + whitespace errors 8-(.. git bz apply 30036 Bug 30036 - Add xslt for authority results normal view in OPAC 130232 - Bug 30036: Add xslt for authority results normal view in OPAC Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30036: Add xslt for authority results normal view in OPAC .git/rebase-apply/patch:107: trailing whitespace. warning: 1 line adds whitespace errors. Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt .git/rebase-apply/patch:107: trailing whitespace. warning: 1 line applied after fixing whitespace errors. Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/staff_interface.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 30036: Add xslt for authority results normal view in OPAC Created attachment 140002 [details] [review] Bug 30036: Add xslt for authority results normal view in OPAC This patch provides a xslt stylesheet on authority results normal view in OPAC. Have a look on opac-authorities-home.pl Test plan: 1)You need the file 'UNIMARCauthResults.xsl' -> get it in the patch from Bug 11083 2)For testing make sure to have at least one or more authorities defined 3)OPAC: Home > Authority search(Submit) > Authority search results 4)Notice the normal view of results 5)Apply patch 6)INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 7)Write the path where your file is, ex: '/home/koha/src/UNIMARCauthResults.xsl' 8)Save changes 9)Repeat 3) and 4) and notice the xslt view of results Created attachment 140332 [details] [review] Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results Patch rebased on master Created attachment 140406 [details] [review] Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results Signed-off-by: David Nind <david@davidnind.com> Created attachment 140407 [details] [review] Bug 30036: (follow-up) Update system preference description Signed-off-by: David Nind <david@davidnind.com> Created attachment 141493 [details] [review] Bug 30036: Allow XSLT for authority results view in OPAC This patch adds a syspref to allow customizing the authority results view at OPAC with XSLT Test plan: 1. For testing make sure to have at least one or more authorities defined 2. OPAC: Home > Authority search(Submit) > Authority search results Notice the normal view of results 3. Apply patch 4. INTRA: Home > Administration > System preferences ->find "AuthorityXSLTOpacResultsDisplay" 5. Write the path where your file is. You can use the one for intranet: .../koha/koha-tmpl/intranet-tmpl/prog/en/XSLT/UNIMARCauthResults.xsl 6. Save changes 7. Repeat step 2 and notice the xslt view of results Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 141494 [details] [review] Bug 30036: (follow-up) Update system preference description Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 141495 [details] [review] Bug 30036: (QA follow-up) Move system preference to OPAC tab * Moves the AuthorityXSLTOpacResultsDisplay from staff interface to OPAC tab * Fixes some capitalization opac in the database pref description Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 142721 [details] [review] Bug 30036: Fix trivial typo Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 142722 [details] [review] Bug 30036: (QA follow-up) Add explanation about default value behavior Devs forgot to mention the default value (empty) is for the current behavior. This is particularly important as there's really no shipped XSLT so a niche usage enhancement until related bugs are pushed. Those only have UNIMARC files, though. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Pushed to master for 22.11. Nice work everyone, thanks! This is marked as a rel_22_05_candidate but it looks like an enhancement. Do we need to backport it? It looks like the keyword was set by Tomas in October - maybe it was just a mistake, meant to be 22.11? (In reply to Katrin Fischer from comment #16) > It looks like the keyword was set by Tomas in October - maybe it was just a > mistake, meant to be 22.11? (In reply to Lucas Gass from comment #15) > This is marked as a rel_22_05_candidate but it looks like an enhancement. Do > we need to backport it? My mistake. Sorry |