Summary: | Add publication date column to serial claims table | ||
---|---|---|---|
Product: | Koha | Reporter: | Lucas Gass (lukeg) <lucas> |
Component: | Serials | Assignee: | Lucas Gass (lukeg) <lucas> |
Status: | CLOSED FIXED | QA Contact: | Victor Grousset/tuxayo <victor> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | arthur.suzuki, jonathan.druart, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.05
|
|
Circulation function: | |||
Attachments: |
Bug 30039: Add published on column to claims.pl
Bug 30039: Add published on column to claims.pl Bug 30039: Add published on column to claims.pl Bug 30039: Add published on column to claims.pl Bug 30039: (QA follow-up) Change published on to publication date |
Description
Lucas Gass (lukeg)
2022-02-07 19:00:16 UTC
Created attachment 130248 [details] [review] Bug 30039: Add published on column to claims.pl To test: 1. Have a vendor setup 2. Go to serials and add a new serial w/ that vendor. 3. When creating a serial make this first issues sometime in the past. 4. Go to Claims, choose your vendor and load the table. 5. No published on column. 6. Apply patch 7. Try step 4 again and now you should see a published on column. Created attachment 134928 [details] [review] Bug 30039: Add published on column to claims.pl To test: 1. Have a vendor setup 2. Go to serials and add a new serial w/ that vendor. 3. When creating a serial make this first issues sometime in the past. 4. Go to Claims, choose your vendor and load the table. 5. No published on column. 6. Apply patch 7. Try step 4 again and now you should see a published on column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Isn't this table already too large? Shouldn't we add the table settings then? (In reply to Jonathan Druart from comment #3) > Isn't this table already too large? Shouldn't we add the table settings then? We should add table settings, yes. I filed Bug 30872. Created attachment 137799 [details] [review] Bug 30039: Add published on column to claims.pl To test: 1. Have a vendor setup 2. Go to serials and add a new serial w/ that vendor. 3. When creating a serial make this first issues sometime in the past. 4. Go to Claims, choose your vendor and load the table. 5. No published on column. 6. Apply patch 7. Try step 4 again and now you should see a published on column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Rebased How does on populate the "published on" column? To check that it's indeed displayed and that search works. Otherwise it looks good for QA (In reply to Victor Grousset/tuxayo from comment #7) > How does on populate the "published on" column? To check that it's indeed > displayed and that search works. > > Otherwise it looks good for QA "Published on" is the date the claimed issue was supposed to be published. I am adding a follow-up to rename the column to 'Publication date' - I think as we are claiming something that has not arrived that might work a little better. Created attachment 137843 [details] [review] Bug 30039: Add published on column to claims.pl To test: 1. Have a vendor setup 2. Go to serials and add a new serial w/ that vendor. 3. When creating a serial make this first issues sometime in the past. 4. Go to Claims, choose your vendor and load the table. 5. No published on column. 6. Apply patch 7. Try step 4 again and now you should see a published on column. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 137844 [details] [review] Bug 30039: (QA follow-up) Change published on to publication date As the issue might not have been published yet, but should have been that seemed a better fit. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for 22.05.05 lots of conflicts on templates. Can you provide a backport patch for 21.11 if needed? (In reply to Arthur Suzuki from comment #13) > lots of conflicts on templates. > Can you provide a backport patch for 21.11 if needed? We don't need this one to be backported to 21.11. |