Bug 30080

Summary: OPACFineNoRenewalsIncludeCredits does not seem to work as indicated
Product: Koha Reporter: Kelly McElligott <kelly>
Component: System AdministrationAssignee: Bugs List <koha-bugs>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: andrew, gmcharlt, jzairo
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Description Kelly McElligott 2022-02-11 12:17:12 UTC 
This system preference: OPACFineNoRenewalsIncludeCredits has two options, Include/Don't Include. 

According to the manual, this preference controls whether the OPACFineNoRenewals function uses the account balance or account amount outstanding (which excludes any credits) to make the calculation. 


Test Plan.
1. Set OPACNOFineNoRenewals to $5
2. Have a patron with a Credit on their account of $20 but also have this patron have fines of $7, therefore the patron should have a $13 credit.
3.Set the system preference OPACFineNoRenewalsIncludeCredits to Include.
4. Attempt to renew an item from the OPAC. 

Koha says, the patron owes $7 and can't renew- Koha is not taking into account this system preference- as the patron should be able to renew because they have a credit.