Summary: | Allow to change "warn when late" setting in subscriptions batch modification tool | ||
---|---|---|---|
Product: | Koha | Reporter: | Julian Maurice <julian.maurice> |
Component: | Serials | Assignee: | Julian Maurice <julian.maurice> |
Status: | Needs Signoff --- | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | Laura.escamilla |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 29996 | ||
Bug Blocks: | |||
Attachments: |
Bug 30095: Add "warn when late" to subscriptions batch mod tool
Bug 30095: Add "warn when late" to subscriptions batch mod tool |
Description
Julian Maurice
2022-02-14 15:25:37 UTC
Created attachment 130549 [details] [review] Bug 30095: Add "warn when late" to subscriptions batch mod tool This patch depends on bug 29996 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions (In reply to Julian Maurice from comment #1) > Created attachment 130549 [details] [review] [review] > Bug 30095: Add "warn when late" to subscriptions batch mod tool > > This patch depends on bug 29996 > > Test plan: > 1. On the Serials module main page, do a search that return at least 2 > subscriptions > 2. Check at least 2 boxes in the first column of the table, then click > on "Edit selected serials" above the table > 3. Verify that the table above the form display correct data for the > "Warn when late" column > 4. Submit the form without changing anything. Verify that the setting > "warn when late" was not changed for selected subscriptions > 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the > form. Verify that the setting "warn when late" was changed to "No" > for all selected subscriptions > 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the > form. Verify that the setting "warn when late" was changed to "Yes" > for all selected subscriptions Received the error: DBIx::Class::Storage::DBI::_dbh_execute(): DBI Exception: DBD::mysql::st execute failed: Unknown column 'me.librarian' in 'field list' at /kohadevbox/koha/Koha/Objects.pm line 96 at /usr/share/perl5/DBIx/Class/Exception.pm line 77 My apologies - this is the correct error code received when applying the patch: Template process failed: file error - parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt line 327: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line 127 Created attachment 175386 [details] [review] Bug 30095: Add "warn when late" to subscriptions batch mod tool This patch depends on bug 29996 Test plan: 1. On the Serials module main page, do a search that return at least 2 subscriptions 2. Check at least 2 boxes in the first column of the table, then click on "Edit selected serials" above the table 3. Verify that the table above the form display correct data for the "Warn when late" column 4. Submit the form without changing anything. Verify that the setting "warn when late" was not changed for selected subscriptions 5. Repeat steps 1 and 2. Set "Warn when late" to "No" and submit the form. Verify that the setting "warn when late" was changed to "No" for all selected subscriptions 6. Repeat steps 1 and 2. Set "Warn when late" to "Yes" and submit the form. Verify that the setting "warn when late" was changed to "Yes" for all selected subscriptions Sponsored-by: Écoles Nationales Supérieures d'Architecture Patch rebased (In reply to Laura Escamilla from comment #3) > My apologies - this is the correct error code received when applying the > patch: > > > Template process failed: file error - parse error - > /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt > line 327: unexpected end of input at /kohadevbox/koha/C4/Templates.pm line > 127 This patch doesn't touch intranet-main.tt so this error must come from elsewhere. |