Summary: | Potential bug source: plenty of "my" declarations with conditional assignments | ||
---|---|---|---|
Product: | Koha | Reporter: | Andrii Nugged <nugged> |
Component: | Architecture, internals, and plumbing | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | minor | ||
Priority: | P5 - low | CC: | fridolin.somers, jonathan.druart, kyle, martin.renvoize |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
22.05.00,21.11.05
|
|
Attachments: |
Bug 30110: Fix concatenation during assignements
Bug 30110: Fix concatenation during assignements Bug 30110: Fix concatenation during assignements |
Description
Andrii Nugged
2022-02-15 13:48:06 UTC
Created attachment 130937 [details] [review] Bug 30110: Fix concatenation during assignements There are several occurrences of `my $var += ` or .= in the code. It should not cause problems but it's confusing. Test plan: Read the patch and confirm that the changes make sense. Surely a lot of copy/paste errors. Looks good to me. Created attachment 132043 [details] [review] Bug 30110: Fix concatenation during assignements There are several occurrences of `my $var += ` or .= in the code. It should not cause problems but it's confusing. Test plan: Read the patch and confirm that the changes make sense. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Created attachment 132188 [details] [review] Bug 30110: Fix concatenation during assignements There are several occurrences of `my $var += ` or .= in the code. It should not cause problems but it's confusing. Test plan: Read the patch and confirm that the changes make sense. Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Funky.. nice bit of clean up, no regressions found. PQA Pushed to master for 22.05, thanks to everybody involved 🦄 Pushed to 21.11.x for 21.11.05 |