Summary: | Value builder for 006 and 008 need choices for all format types | ||
---|---|---|---|
Product: | Koha | Reporter: | Jane Wagner <jwagner> |
Component: | Cataloging | Assignee: | Salva Zaragoza Rubio <salva> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P5 - low | CC: | bargioni, chagal, chris, cnighswonger, cookie.wolfrom, dgrobani, gmcharlt, koha.sekjal, mjr, mtj, paul.poulain, salva |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5196 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Attachments: |
Proposed fix
Cataloguing plugin for fields 006/008, Type of Material Display and form variation with type of material selection. follow up patch Erase merge conflict marker left and replace XMLHttpRequest with jQuery Value builder for 006 and 008 need choices for all format types |
Description
Chris Cormack
2010-05-21 01:05:23 UTC
Restoring where "Previous assignee was mjr@ttllp.co.uk" A bug for the 006 field has been filed - basically when a selection is made in one subfield it should effect the options in the other subfields. Created attachment 2641 [details] [review] Proposed fix This partial fix adds a complete list of values for 006/00, "Form of material," following the list found here: http://www.loc.gov/marc/bibliographic/bd006.html Pushed patch, please test This bug has a patch presently committed to HEAD and 3.2.x. Please take the appropriate action to update the status of this bug. Remember, bugs which have been resolved should be tested and marked closed, preferably by the original reporter. This bug has a fix which was committed to the 3.2.x branch and released in 3.2.1. Please take time to update the status of this bug and mark it RESOLVED FIXED so that it may be closed. commit 6aee235e3c239fd46ffdc263bafd578d845e812b calls itself a "partial fix". Where is the fix for 008? I'm not finding it. You are correct. Sorry. I failed to cull this one from my list. This bug is mentioned in: Fix for Bug 3013, Value builder for 006 and 008 need choices for all format types http://lists.koha-community.org/pipermail/koha-patches/2010-November/013047.html Hi, i would like to know if someone is currently developing the 008 choices for all format types, from what i've read the 006 one is completed but i'm not so sure about the 008 one. We were thinking on picking up this issue and using mysql tables to store the different values instead of hard coding them on the tmpl. Let me know what you think. Created attachment 3247 [details] [review] Cataloguing plugin for fields 006/008, Type of Material Display and form variation with type of material selection. Hi, I've added on the cataloguing plugin for 006/008 fields the possibility to select a type of material and to change the displayed form to view the allowed positions and enter the data accordingly. The positions that require one char are presented as a combo, the positions with multiple chars are presented as a text field without restrinctions on value. At the top of the plugin exists a grid-row with the current values for each position and its validity. The allowed values are those defined on http://www.loc.gov/marc/bibliographic/bd006.html and http://www.loc.gov/marc/bibliographic/bd008.html. They are stored in xml files to allow easy processing through Javascript and AJAX. Also to allow easy translation when needed. I've added a new system preference "TypeOfMaterialsView_006_008" that activates this new functionality, or as default lets you to continue with the current one. So you can choose which one to use. This functionality is implemented in the intranet -> Cataloging -> Add MARC Record I attach proposed patch to test. Regards Salva Created attachment 3248 [details] [review] follow up patch I have signed off on the first patch and submit this follow up for sign off. It updates the way the preference is worded in English to make more sense to users. Nicole Engard: thanks for correcting the system preference. Mike Hafen: didn't see that one, thanks for detecting it. I'll correct it right away. Galen Charlton: the system preference was just for keeping the current implementation and the new one. I didn't want to impose something new over something people is using all along. I thought jQuery.load() and jQuery.ajax() were basically front-ends for XMLHttpRequest and was indifferent which one to use, anyway I'll change the code to implement jQuery and I'll post again the patch. Thanks for your comments and advice. Regards Salva Created attachment 3251 [details] [review] Erase merge conflict marker left and replace XMLHttpRequest with jQuery Erase merge conflict marker left on unimarc_standard_systemprefs.sql. Replace XMLHttpRequest call for xml with jQuery Ajax interface. Delete alert. Should you also remove the system preference and make this the default? Sounds like that's the best way to go - especially since your way is the proper way :) Ok, I'll make a new patch without the system preference. I'll post it when finished. Thanks Salva Created attachment 3259 [details] [review] Value builder for 006 and 008 need choices for all format types Hi, Patch replacing current 006/008 plugin and without the system preference. Salva Signed off on new patch! Works awesome. Pushed and merged please test and mark resolved (In reply to comment #20) > Pushed and merged please test and mark resolved I tested the latest patch (attachment 3259 [details] [review]) in Koha 3.2.3. It seems ok for both 006 and 008. Pushed to 3.2.x. We've started having an intermittent problem with the 008 with non-book materials. When the material type is changed, it changes the data elements correctly, but after the information is entered, and ok is clicked, sometimes characters are dropped from the entry in the field itself. You can go back and reenter the data and click ok again and sometime that time and sometimes the next it will enter correctly. The only thing in the error log is something like: [Fri Aug 26 09:18:55 2011] [error] [client 10.8.5.66] [Fri Aug 26 09:18:55 2011] addbiblio.pl: substr outside of string at /usr/share/perl5/MARC/File/XML.pm line 317. [Fri Aug 26 09:18:55 2011] [error] [client 10.8.5.66] [Fri Aug 26 09:18:55 2011] addbiblio.pl: Use of uninitialized value $original_encoding in string ne at /usr/share/perl5/MARC/File/XML.pm line 320. QA comment: I don't understand what is already applied an available in 3.4, what is still pending. I feel we're waiting for one more patch, that is not here, so this bug should not be "signed off" Resetting status, as we don't have an updated patch to address the issues I've noted in comment 23 (In reply to Ian Walls from comment #25) > Resetting status, as we don't have an updated patch to address the issues > I've noted in comment 23 some good news here... i just searched thru 1 years worth of Koha 'production' error logs (v3.14.6), and could not find Ian's error. perhaps this bug has been somehow resolved? is anyone from Bywater still getting these errors? *** Bug 5196 has been marked as a duplicate of this bug. *** I am not sure why this was left in discussion - several patches have been pushed to really old versions of Koha here. I think if any issues remain, we'll need new bugs. |