Description
Martin Renvoize (ashimema)
2022-02-18 13:38:46 UTC
Created attachment 130852 [details] [review] Bug 30130: Add standard to edi account definition This patch add a 'standard' field to the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. Created attachment 130860 [details] [review] Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. 1) Having the descriptions come from the .pl file doesn't sit well with me. Although I think in these cases a change for translation is probably unlikely. If something else was to be added, like an explanatory note, we for sure would need to move it out to the templates. Maybe we could consider moving it anyway for better coding practice? 2) I think QA would love some unit tests on the change in Order.pm 3) Schema change should have been a separate patch ;) All those are not being blockers for my sign-off, but: 4) The summary table shows the code instead of the description. The form and the summary table should match up. 5) The atomic file needs the executable flag to be added (I had done this in a follow-up, but I think better you do it when fixing 4) ) Created attachment 130960 [details] [review] Bug 30130: (QA follow-up) Move description to template Created attachment 130966 [details] [review] Bug 30130: Add standard field to edi_account This patch add a 'standard' field to the edifact account configuration table to allow setting the message standard as either 'EDItEUR' or 'BiC'. Created attachment 130967 [details] [review] Bug 30130: DBIC Update This patch updates the DBIC schema's with the new 'standard' field. Created attachment 130968 [details] [review] Bug 30130: Use new standard field in account definition This patch uses the new 'standard' field to in the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. Created attachment 130969 [details] [review] Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. Created attachment 130970 [details] [review] Bug 30130: Unit tests This patch adds a unit test for the internal 'beginning_of_message' method in Koha::Edifact::Order to check that the vendor standard parameter is being interpreted coorectly. Test plan 1. Run the tests, they should pass Patches split as requested, tests added as requested, translations moved as requested.. back to NSO Created attachment 130991 [details] [review] Bug 30130: Add standard field to edi_account This patch add a 'standard' field to the edifact account configuration table to allow setting the message standard as either 'EDItEUR' or 'BiC'. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130992 [details] [review] Bug 30130: DBIC Update This patch updates the DBIC schema's with the new 'standard' field. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130993 [details] [review] Bug 30130: Use new standard field in account definition This patch uses the new 'standard' field to in the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130994 [details] [review] Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130995 [details] [review] Bug 30130: Unit tests This patch adds a unit test for the internal 'beginning_of_message' method in Koha::Edifact::Order to check that the vendor standard parameter is being interpreted coorectly. Test plan 1. Run the tests, they should pass Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 130996 [details] [review] Bug 30130: (QA follow-up) Fix permission on atomic update file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 132404 [details] [review] Bug 30130: Add standard field to edi_account This patch add a 'standard' field to the edifact account configuration table to allow setting the message standard as either 'EDItEUR' or 'BiC'. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132405 [details] [review] Bug 30130: DBIC Update This patch updates the DBIC schema's with the new 'standard' field. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132406 [details] [review] Bug 30130: Use new standard field in account definition This patch uses the new 'standard' field to in the edifact account configuration area to allow setting the message standard as either 'EDItEUR' or 'BiC'. This just replaces the currently hard coded hash of SAN's in Koha::Edifact::Order to distinguish between the two standards instead of requireing a bug submission per vender san we identify to be a BiC type vendor. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132407 [details] [review] Bug 30130: (follow-up) Set BiC for 'Ulverscroft' The 'Ulverscroft' supplier is also a BiC follower, this patch adds their SAN, 5013546031839, to the DB update. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132408 [details] [review] Bug 30130: Unit tests This patch adds a unit test for the internal 'beginning_of_message' method in Koha::Edifact::Order to check that the vendor standard parameter is being interpreted coorectly. Test plan 1. Run the tests, they should pass Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132409 [details] [review] Bug 30130: (QA follow-up) Fix permission on atomic update file Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Created attachment 132410 [details] [review] Bug 30130: (QA follow-up) Fix tests Result was copied and pasted, needed to update check Was passing objetc instead of standard field Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 22.05, thanks to everybody involved [U+1F984] |