Bug 30154

Summary: AuthorityControlledIndicators copies empty indicators as space making it hard to edit in cataloguing
Product: Koha Reporter: Noémie Labine <noemie.labine>
Component: CatalogingAssignee: Bugs List <koha-bugs>
Status: CLOSED INVALID QA Contact: Testopia <testopia>
Severity: minor    
Priority: P5 - low CC: januszop, m.de.rooy
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 14769    
Bug Blocks:    

Description Noémie Labine 2022-02-22 15:47:53 UTC
I'm not sure I can explain it clearly in english :-) so here is the test plan :

1. Add a new record.
2. In 830$a, enter a title that can't be link, for exemple Lion.
3. Click on Link authority automatically, you will have a No matching authority found result.
4. Next to the $9 subfield, the + icon will appear to create an authority.
5. Click on it and create the authority.
5. Save the new authority and come back to your record.
6. Click on the second indicator box and try to enter an indicator. You will not be able to enter anything.


To be able to enter a second indicator you either have to 
1. click on the first indicator box than use TAB to make your cursor go in the second box
2. save the record then edit it to add the indicator
3. enter the indicator when you create the authority

Tested it with other fields (800, 810...) and 830 is the only field where this happens.
Comment 1 Katrin Fischer 2022-02-26 23:45:37 UTC
Hi Noemie, you described it perfectly and I can confirm the behavior on the latest development version as well.

I believe this is due to the AuthorityControlledIndicators system preference. It's defined there, that the second indicator will be copied from the authority record.

If you haven't set any indicator in the authority, it will copy a 'space'. As the input is set to only allow you to enter one character, it looks like you can't enter anything.

For the other fields you tested the second indicator is not taken from the authority, so that would explain the difference.

But: Click into the field and then hit backspace/delete the space. Then you can add your indicator.
Comment 2 Janusz Kaczmarek 2022-02-27 17:02:57 UTC
(In reply to Katrin Fischer from comment #1)
> Hi Noemie, you described it perfectly and I can confirm the behavior on the
> latest development version as well.
> 
> I believe this is due to the AuthorityControlledIndicators system
> preference. It's defined there, that the second indicator will be copied
> from the authority record.
> 
> If you haven't set any indicator in the authority, it will copy a 'space'.
> As the input is set to only allow you to enter one character, it looks like
> you can't enter anything.
> 
> For the other fields you tested the second indicator is not taken from the
> authority, so that would explain the difference.
> 
> But: Click into the field and then hit backspace/delete the space. Then you
> can add your indicator.

I could only add that it is completely correct and wanted behavior.  Assuming that we are in MARC 21 domain, in case of the bibliographic field 830 the second indicator should be equal (and should be taken/copied) from the second indicator of the field 130 of the linked authority record (cf. https://www.loc.gov/marc/authority/ad130.html and https://www.loc.gov/marc/bibliographic/bd830.html). 

Therefor it should be enough to set correctly the 2nd indicator in the entry field (i.e. 130) of the authority record (checked in my test environment--works like it should).

BTW, please, pay attention that according to MARC 21 definition, the second indicator in the field 130 in the authority record should never be blank/empty.

To sum this up--IMHO, this is not a bug at all.
Comment 3 Noémie Labine 2022-02-28 20:14:54 UTC
Thanks to both of you. It indeed seems to be a normal behaviour as the second indicator is copied from the authority record.

However, I understand the second indicator is not 'supposed' to be empty, but the library that submitted this problem to us seems to have quite a few Uniform title authories created without a second indicator. I assume that it isn't the only library where the Marc 21 standards are not fully respected or at least that sometimes an indicator can be forgotten. Therefore, this behavior still makes it hard to correct the indicator.

I know the 'right' way to correct the mistake would be to add the indicator in the authority record before adding the 830 in the record... but I'm thinking about situations where the person cataloguing wants to do it 'quickly' or for any other reason they decide not to correct the autority record.

Plus, now that I understand where this comes from, I can reecreate in any other field with the first or the second indicator. For exemple, in a 700 field with a person's name without a first indicator. 

I would really understand if we decide to not fix this as it is not a 'real' problem if Marc21 standards are respected, but I do think it would lack consistency if we consider that we can very well create the authority without completely respecting Marc21, since we can save it without putting an indicator in the first place.
Comment 4 Janusz Kaczmarek 2022-02-28 22:03:05 UTC
Thank you for explaining the context.  Verifying the formal correctness of the MARC 21/UNIMARC records is quite a complex issue and--as far as I know--it is beyond of what Koha can do at the time (although it would be great if we could have some validation rules).  For now we are able to establish and control, quite precisely, the coherence between the authority data and bibliographic records. 

The library should be aware that with the standard AuthorityControlledIndicators values, even if a librarian places by hand a correct value of a controlled indicator in the biblio records, every modification of the linked authority record without the correct indicator will reset the indicator in the biblio records fields.  So, the library should either correct the authority records (which will also correct the indicators in the linked biblio records fields, which is great) or clear appropriate lines in the AuthorityControlledIndicators system preference in order to prevent this (very useful, and correct, and wanted) behavior of the controlled indicators "mini engine".
Comment 5 Marcel de Rooy 2022-03-01 12:31:47 UTC
By default, you will find this entry for UNIMARC in your ControlledIndicators preference:

# UNIMARC: Always copy the indicators from the authority
unimarc, *, ind1:auth1, ind2:auth2

If you don't want this behaviour, a simple remedy is to comment that last line starting with unimarc.
I would not recommend doing so but it is possible to just ignore standards and the like ;)
Comment 6 Marcel de Rooy 2022-03-01 12:32:03 UTC
I recommend closing this report. It is no bug.
Comment 7 Noémie Labine 2022-03-01 13:49:55 UTC
The library did clear the appropriate line in AuthorityControlledIndicators and decided to put a default value of 0 for the second indicator of their 830 field. I believe they will correct the authority records as they see them. In the end, they do know that it would be prefereable to keep every line in AuthorityControlledIndicators and correct any empty indicator they would find in Uniform title authority.

I'm closing this report, thanks for taking the time.

Have a nice day everyone !