| Summary: | background_jobs.status should be an ENUM | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Component: | Architecture, internals, and plumbing | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> | 
| Status: | Failed QA --- | QA Contact: | Testopia <testopia> | 
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | david, dcook, jonathan.druart, kyle, m.de.rooy, martin.renvoize, nick, tomascohen | 
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Crowdfunding goal: | 0 | 
| Patch complexity: | Trivial patch | Documentation contact: | |
| Documentation submission: | Text to go in the release notes: | ||
| Version(s) released in: | Circulation function: | ||
| Bug Depends on: | |||
| Bug Blocks: | 35092 | ||
| Attachments: | Bug 30182: Make background_jobs.status an ENUM Bug 30182: DBIC update Bug 30182: DBIC update Bug 30182: Make background_jobs.status an ENUM Bug 30182: DBIC update | ||
| 
        
          Description
        
        
          Tomás Cohen Arazi (tcohen)
        
        
        
        
          2022-02-25 10:26:31 UTC
        
       Created attachment 131109 [details] [review] Bug 30182: Make background_jobs.status an ENUM Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 131110 [details] [review] Bug 30182: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Patch no longer applies 8-( git bz apply 30182 Bug 30182 - background_jobs.status should be an ENUM 131109 - Bug 30182: Make background_jobs.status an ENUM 131110 - Bug 30182: DBIC update Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30182: Make background_jobs.status an ENUM Applying: Bug 30182: DBIC update Using index info to reconstruct a base tree... M Koha/Schema/Result/BackgroundJob.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/BackgroundJob.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/BackgroundJob.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 30182: DBIC update hint: Use 'git am --show-current-patch=diff' to see the failed patch Testing notes: - Before patch is applied show details for column in the database: . show create table background_jobs; . select * from background_jobs where status=0; - After patch is applied: should show enum values as per the patch Created attachment 135327 [details] [review] Bug 30182: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 135330 [details] [review] Bug 30182: Make background_jobs.status an ENUM Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Created attachment 135331 [details] [review] Bug 30182: DBIC update Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> admin/background_jobs.tt has also "running" and "failed". Not sure "running" actually exists/makes sense. But "failed" does. |